Skip to content

Use _pending for the latest changelog entries#1817

Merged
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:use-pending-for-changelog
Jul 11, 2017
Merged

Use _pending for the latest changelog entries#1817
dlang-bot merged 1 commit intodlang:masterfrom
wilzbach:use-pending-for-changelog

Conversation

@wilzbach
Copy link
Copy Markdown
Contributor

Regarding #1814 (comment)

A simple solution is to use _pending for the automatically generated changelog. (@MartinNowak) doesn't seem to use the Makefile target here anyways.

Regarding the changelog menu: I wasn't really sure how we should handle the case when a prerelease is progress, so I simply renamed them "Nightlies" as this actually is exactly what the page depicts.

CC @CyberShadow

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@CyberShadow
Copy link
Copy Markdown
Member

Looks like we had the same idea: dlang/phobos#5504 (comment)

@dlang-bot dlang-bot merged commit a9c0482 into dlang:master Jul 11, 2017
@CyberShadow
Copy link
Copy Markdown
Member

Thanks!

The _pre page still has nothing on it to indicate it's not yet released, except the future date and URL, sigh.

@wilzbach wilzbach deleted the use-pending-for-changelog branch July 12, 2017 13:42
@wilzbach
Copy link
Copy Markdown
Contributor Author

Hmm any idea what could have went wrong with the deployment?
The changes were properly shown in DAutoTest, but aren't visible on dlang.org, e.g.

http://dlang.org/changelog/2.075.0_pending.html

@MartinNowak
Copy link
Copy Markdown
Member

What was the point of using 2.076.0_pending.html instead of just 2.076.0.html having pending somewhere clearly visible on the page?

@CyberShadow
Copy link
Copy Markdown
Member

I think because update_nav.sh infers the page type from the filename?

@wilzbach
Copy link
Copy Markdown
Contributor Author

What was the point of using 2.076.0_pending.html instead of just 2.076.0.html having pending somewhere clearly visible on the page?
I think because update_nav.sh infers the page type from the filename?

Yes, and also it's not trivial to know the future release version of master as this would require detecting the beta tags and this _pending seemed a lot easier.

MartinNowak added a commit to MartinNowak/dlang.org that referenced this pull request Jul 16, 2017
…hangelog"

This reverts commit a9c0482, reversing
changes made to ea0c2de.
dlang-bot added a commit that referenced this pull request Jul 16, 2017
Revert "Merge pull request #1817 from wilzbach/use-pending-for-changelog"
merged-on-behalf-of: Sebastian Wilzbach <sebi.wilzbach@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants