Skip to content

Revert "Merge pull request #1817 from wilzbach/use-pending-for-changelog"#1826

Merged
dlang-bot merged 1 commit intodlang:masterfrom
MartinNowak:fixup_pre_changelog
Jul 16, 2017
Merged

Revert "Merge pull request #1817 from wilzbach/use-pending-for-changelog"#1826
dlang-bot merged 1 commit intodlang:masterfrom
MartinNowak:fixup_pre_changelog

Conversation

@MartinNowak
Copy link
Copy Markdown
Member

@MartinNowak MartinNowak commented Jul 16, 2017

This reverts commit a9c0482, reversing
changes made to ea0c2de.

See #1823 (comment) and #1821 (comment). Let's take the time necessary to do this properly.

…hangelog"

This reverts commit a9c0482, reversing
changes made to ea0c2de.
@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request, @MartinNowak!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@MartinNowak MartinNowak requested a review from wilzbach July 16, 2017 12:20
Copy link
Copy Markdown
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not happy, but I see your point about having a longer discussion and I don't care strongly about _pending atm.

@dlang-bot dlang-bot merged commit 1692886 into dlang:master Jul 16, 2017
@MartinNowak MartinNowak deleted the fixup_pre_changelog branch July 16, 2017 12:37
@CyberShadow
Copy link
Copy Markdown
Member

@MartinNowak Alright, so what's the next step from here, the NEXT_VERSION file? Will you be doing that or should I or @wilzbach have a go?

@wilzbach
Copy link
Copy Markdown
Contributor

@MartinNowak Alright, so what's the next step from here, the NEXT_VERSION file? Will you be doing that or should I or @wilzbach have a go?

FYI: I created a Trello card to track the progress: https://trello.com/c/Lu1mDNYO/336-rework-changelog-generation-at-dlangorg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants