Skip to content

Rename VERSION => STABLE_VERSION for the unification at the changed tool#1824

Closed
wilzbach wants to merge 1 commit intodlang:masterfrom
wilzbach:unify-changelog-version
Closed

Rename VERSION => STABLE_VERSION for the unification at the changed tool#1824
wilzbach wants to merge 1 commit intodlang:masterfrom
wilzbach:unify-changelog-version

Conversation

@wilzbach
Copy link
Copy Markdown
Contributor

Small-scale version of #1821, s.t. we can move step by step.

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@wilzbach
Copy link
Copy Markdown
Contributor Author

As mentioned before, if change.d would be part of this repo I wouldn't need to go through these hops to please DAutoTest)...

Log</option>

VERSION=
STABLE_VERSION=
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fair: it wouldn't be too hard to continue to generate VERSION at the changed.d script, but imho this helps clarifying things.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I have the same understanding of STABLE_VERSION as you, so far we used that term to pin tools/compilers, but not for anything in our docs/targets.

@MartinNowak
Copy link
Copy Markdown
Member

Let's wait a sec and properly think this through before churning more code.
#1821 (comment)

@wilzbach wilzbach closed this Jul 17, 2017
@wilzbach wilzbach deleted the unify-changelog-version branch July 17, 2017 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants