Skip to content

Rename VERSION => STABLE_VERSION for the unification at the changed tool #1824

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wilzbach wants to merge 1 commit into from
Closed

Rename VERSION => STABLE_VERSION for the unification at the changed tool #1824

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion changelog/changelog.ddoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,14 +15,15 @@ SUBNAV=$(SUBNAV_TEMPLATE
SEARCH_OPTIONS_EXTRA=<option value="dlang.org/changelog" selected>Change
Log</option>

VERSION=
STABLE_VERSION=
Copy link
Copy Markdown
Contributor Author

@wilzbach wilzbach Jul 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be fair: it wouldn't be too hard to continue to generate VERSION at the changed.d script, but imho this helps clarifying things.

Copy link
Copy Markdown
Member

@MartinNowak MartinNowak Jul 16, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I have the same understanding of STABLE_VERSION as you, so far we used that term to pin tools/compilers, but not for anything in our docs/targets.

$(DIVC version,
$(P
$(B $(LARGE $(LINK2 http://downloads.dlang.org/releases/2.x/$(VER), Download D $(VER))))$(BR)
$(SMALL released $1, $2)
)
$4
)
VERSION=$0

NIGHTLY_VERSION=
$(DIVC version,
Expand Down