Skip to content

Comments

Bump versions#2551

Closed
wilzbach wants to merge 2 commits intodlang:masterfrom
wilzbach:bump-versions
Closed

Bump versions#2551
wilzbach wants to merge 2 commits intodlang:masterfrom
wilzbach:bump-versions

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Jan 10, 2019

Required for some PRs at DMD and while I was at it I thought I bump everything.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@PetarKirov
Copy link
Member

@wilzbach this fails with:

[..]
ddoc_preprocessor ~master: building configuration "executable"...
ddoc/source/assert_writeln_magic.d(75,13): Error: no property `assertion` for type `const(AssertExpression)`
ddoc/source/assert_writeln_magic.d(195,25): Error: template instance `assert_writeln_magic.TestVisitor!(FileLines)` error instantiating
.generated/stable_dmd-2.083.0/dmd2/linux/bin64/dmd failed with exit code 1.
posix.mak:921: recipe for target '.generated/ddoc_preprocessor' failed
make[1]: *** [.generated/ddoc_preprocessor] Error 2
make[1]: Leaving directory '/home/circleci/dlang.org'
posix.mak:373: recipe for target 'release' failed
make: *** [release] Error 2
Exited with code 2

@wilzbach
Copy link
Contributor Author

So it looks like we can't upgrade to libdparse 0.10 fully, because ddox only supports 0.8. I added a workaround to the assert_rewrite_magic, let's see what this leads to.

@Geod24
Copy link
Member

Geod24 commented May 1, 2020

Superseeded by #2758

@Geod24 Geod24 closed this May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants