Update assert_writeln_magic to the latest libdparse#2758
Merged
dlang-bot merged 3 commits intodlang:masterfrom Aug 4, 2020
Merged
Update assert_writeln_magic to the latest libdparse#2758dlang-bot merged 3 commits intodlang:masterfrom
dlang-bot merged 3 commits intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @Geod24! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
thewilsonator
approved these changes
Feb 19, 2020
Member
Author
|
For reference I see 2,131 parsing errors on a recent build, in the form: |
Member
Author
|
Blocked by dlang-community/libdparse#383 |
Closed
69086f2 to
b1092f4
Compare
Member
Author
|
Great, this is now blocked on an update to |
So that the shebang can be used.
I noticed on the CI that this was throwing a lot of errors. Turns out it was using a libdparse from late 2017, which didn't knew about a lot of syntax changes, such as 'body' -> 'do', new contract syntax, extern(C++, string)... The two small changes required were introduced by: - dlang-community/libdparse@daa93a5#diff-277d73641e4843decd9c9a41c6c23046L820 - dlang-community/libdparse@e625d2b#diff-ad149e8970c93d472185f0fb76ffcaeaR86
Member
Author
|
After almost 6 months, this is finally ready to go 🎉 There are still a few issues showing up, but much less than there used to be, so yay? Additionally, a lot of what I think are false positive because of this: I don't think libdparse handles ddoc correctly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed on the CI that this was throwing a lot of errors.
Turns out it was using a libdparse from late 2017,
which didn't knew about a lot of syntax changes,
such as 'body' -> 'do', new contract syntax, extern(C++, string)...
The two small changes required were introduced by: