Skip to content

document open GC registry#2577

Merged
wilzbach merged 1 commit intodlang:masterfrom
rainers:gc_registry
Feb 18, 2019
Merged

document open GC registry#2577
wilzbach merged 1 commit intodlang:masterfrom
rainers:gc_registry

Conversation

@rainers
Copy link
Copy Markdown
Member

@rainers rainers commented Feb 15, 2019

documentation for dlang/druntime#1924

@dlang-bot
Copy link
Copy Markdown
Contributor

dlang-bot commented Feb 15, 2019

Thanks for your pull request, @rainers!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@rainers rainers mentioned this pull request Feb 15, 2019
Merged
wilzbach
wilzbach reviewed Feb 15, 2019
View reviewed changes
spec/garbage.dd Outdated

$(P You can also remove the standard GC implementation from a statically
linked binary by redefining the function `extern(C) void* register_default_gcs()`.
This will cause all attempts to allocate GC managed memory to terminate
Copy link
Copy Markdown
Contributor

@wilzbach wilzbach Feb 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add sth. like "if no custom GC has been registered ..."

Copy link
Copy Markdown
Member Author

@rainers rainers Feb 15, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, done.

@rainers
Copy link
Copy Markdown
Member Author

rainers commented Feb 17, 2019

Anything holding this back? The beta changelog already links to this documentation.

@thewilsonator
Copy link
Copy Markdown
Contributor

thewilsonator commented Feb 17, 2019

Its labelled as waiting on a DMD PR. @wilzbach which one?

@rainers
Copy link
Copy Markdown
Member Author

rainers commented Feb 17, 2019

Its labelled as waiting on a DMD PR. @wilzbach which one?

I guess that was meant for the druntime PR dlang/druntime#1924

@PetarKirov
Copy link
Copy Markdown
Member

PetarKirov commented Feb 18, 2019

Are we going to wait for dlang/druntime#2491?

@wilzbach wilzbach merged commit 2a43248 into dlang:master Feb 18, 2019
@wilzbach
Copy link
Copy Markdown
Contributor

wilzbach commented Feb 18, 2019

Are we going to wait for dlang/druntime#2491?

2.085 will come with this feature, so we should at least document it (even if it's a bit harder to use).
Though once dlang/druntime#2491 is merged, we should probably update this page with the appropriate imports to core.gc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

@andralex andralex Awaiting requested review from andralex andralex is a code owner

@WalterBright WalterBright Awaiting requested review from WalterBright WalterBright is a code owner

+2 more reviewers

@wilzbach wilzbach wilzbach left review comments

@jacob-carlborg jacob-carlborg jacob-carlborg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rainers @dlang-bot @thewilsonator @PetarKirov @wilzbach @jacob-carlborg