move modules necessary to implement a GC to core.gc#2491
move modules necessary to implement a GC to core.gc#2491dlang-bot merged 2 commits intodlang:masterfrom
Conversation
|
Thanks for your pull request, @rainers! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2491" |
|
|
||
| import gc.config; | ||
| import gc.gcinterface; | ||
| import core.gc.gcinterface; |
There was a problem hiding this comment.
Couldn't this file import the declarations from gc.proxy instead of defining the headers again?
There was a problem hiding this comment.
Not sure what you mean. Do you prefer a cyclic dependency and a public import in gc.proxy over a simple import of the public module?
There was a problem hiding this comment.
Do you prefer a cyclic dependency
Ah sorry. Nevermind then.
There was a problem hiding this comment.
Ah, I didn't see the gc_* declarations in the diff. I think we have these declarations elsewhere too, e.g. core.memory. IIRC this is done to fake some attributes.
| */ | ||
|
|
||
| module gc.config; | ||
| module core.gc.config; |
There was a problem hiding this comment.
Do we want to expose this to the user and docs? Maybe make everything package for now?
There was a problem hiding this comment.
I think a GC implementation should be able to use the configuration even if it does not support all the values in there.
There was a problem hiding this comment.
Maybe make everything
packagefor now?
That would disallow accessing these modules from package gc AFAICT.
There was a problem hiding this comment.
That would disallow accessing these modules from package gc AFAICT.
Fair enough.
This allows compiling new GC implementations without requiring adding an import path to druntime/src.
Not sure if this is better than just adding the 3 gc-files to the import folder as is. Comments?