Skip to content

Comments

[WIP] Translate _d_array{,set}ctor to templates#10102

Closed
Vild wants to merge 3 commits intodlang:masterfrom
Vild:ConvertArrayCtorHook
Closed

[WIP] Translate _d_array{,set}ctor to templates#10102
Vild wants to merge 3 commits intodlang:masterfrom
Vild:ConvertArrayCtorHook

Conversation

@Vild
Copy link
Contributor

@Vild Vild commented Jun 27, 2019

druntime PR: dlang/druntime#2655

@dlang-bot
Copy link
Contributor

dlang-bot commented Jun 27, 2019

Thanks for your pull request and interest in making D better, @Vild! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10102"

Vild added 3 commits July 8, 2019 22:47
Signed-off-by: Dan Printzell <xwildn00bx@gmail.com>
Signed-off-by: Dan Printzell <xwildn00bx@gmail.com>
Signed-off-by: Dan Printzell <xwildn00bx@gmail.com>
@Vild Vild force-pushed the ConvertArrayCtorHook branch from fb91209 to e7c81c3 Compare July 8, 2019 20:52
@JinShil
Copy link
Contributor

JinShil commented Jul 21, 2019

@Vild Does this just need a rebase?

@Vild
Copy link
Contributor Author

Vild commented Jul 21, 2019

@Vild Does this just need a rebase?

I found some bugs when compiling with -O, so I'm currently looking into them.

@Vild Vild changed the title Translate _d_array{,set}ctor to templates [WIP] Translate _d_array{,set}ctor to templates Jul 23, 2019
@dlang-bot dlang-bot added the Review:WIP Work In Progress - not ready for review or pulling label Jul 23, 2019
@UplinkCoder
Copy link
Member

Why did this need changes to ctfe?

@RazvanN7
Copy link
Contributor

Superseded by: #13116

@RazvanN7 RazvanN7 closed this Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Review:Needs Rebase Review:stalled Review:WIP Work In Progress - not ready for review or pulling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants