Translate _d_array{,set}ctor to templates

[Vild]

DMD PR: dlang/dmd#10102

• This adds rt.util.array to mak/COPY as its a dependency for _d_arrayctor
• _d_array{,set}ctor uses @trusted to not break code, pure and nothrow can be automatically deduced by the compiler
• _d_arraysetctor no longer returns a return value as it causes warnings:

std/container/array.d(97): Warning: calling rt.array.constructor._d_arraysetctor!(const(Array!int))._d_arraysetctor without side effects discards return value of type const(Array!int)[], prepend a cast(void) if intentional

[dlang-bot]

Thanks for your pull request and interest in making D better, @Vild! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2655"

[jpf91]

Just for reference, this means calling destructors will not be done if the postblit threw a non-exception throwable. IIRC the language spec allows this behaviour @WalterBright @andralex ?

[JinShil]

See

druntime/src/rt/arrayassign.d

Lines 180 to 199 in ab890e0

	try
	{
	for (i = 0; i < to.length; i++)
	{
	// Copy construction is defined as bit copy followed by postblit.
	memcpy(to.ptr + i * element_size, from.ptr + i * element_size, element_size);
	ti.postblit(to.ptr + i * element_size);
	}
	}
	catch (Throwable o)
	{
	/* Destroy, in reverse order, what we've constructed so far
	*/
	while (i--)
	{
	ti.destroy(to.ptr + i * element_size);
	}
	throw o;
	}

for the genesis of that code.

[jpf91]

LGMT, but the windows Makefile needs to be fixed. @Vild is this PR ready?

[JinShil]

Should this code be calling object.destroy instead?

[Vild]

I changed it object.destroy and object._postblitRecurse for the postblit.

[Vild]

I would call this PR ready.

About the windows build problem, I'm not sure why this is happening.

copy src\rt\util\array.d  import\rt\util\array.d
The system cannot find the path specified.
        0 file(s) copied.

But the file exist when I check: ls src/rt/util/array.d

[JinShil]

@rainers We're getting the following build error on Windows

..\..\druntime\import\rt\array\construction.d(32): Error: module `array` is in file 'rt\util\array.d' which cannot be read

It appears all the right makefile modifications have been made. Do you happen to know why this error is occurring?

[rainers]

About the windows build problem, I'm not sure why this is happening.

copy src\rt\util\array.d  import\rt\util\array.d
The system cannot find the path specified.

The problem is that the output directory does not exist. It should be added similar to https://github.com/dlang/druntime/blob/master/mak/WINDOWS#L57

While you are at it, you could also add core\sys\netbsd\sys and core\sys\netbsd.

[thewilsonator]

It seems like the exception paths are not tested, could you add some tests that exercise those? Otherwise looks good.

[Vild]

@thewilsonator done

This PR is ready to be merged.