Skip to content

fix range error with -mscrtlib=#10408

Merged
dlang-bot merged 1 commit intodlang:masterfrom
rainers:mscrtlib_rangeerror
Sep 17, 2019
Merged

fix range error with -mscrtlib=#10408
dlang-bot merged 1 commit intodlang:masterfrom
rainers:mscrtlib_rangeerror

Conversation

@rainers
Copy link
Member

@rainers rainers commented Sep 15, 2019

The range error doesn't trigger in released versions because they are built without boundschecks.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @rainers!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10408"

@Geod24
Copy link
Member

Geod24 commented Sep 15, 2019

Another hint that an array in a boolean context should check length and not .ptr.
Looks like this fails tho.

@rainers
Copy link
Member Author

rainers commented Sep 15, 2019

Another hint that an array in a boolean context should check length and not .ptr.

Both are tested and have to be 0/null for the boolean to be false.

Looks like this fails tho.

Looks unrelated, This build has the same problem: https://dev.azure.com/dlanguage/dmd/_build/results?buildId=4590

@dlang-bot dlang-bot merged commit 1e2d9c2 into dlang:master Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants