use ref for OutBuffer rather than *#10410
Merged
dlang-bot merged 1 commit intodlang:masterfrom Sep 17, 2019
Merged
Conversation
WalterBright
added
Review:Easy Review
Severity:Refactoring
WalterBright
requested review from
andralex and
jacob-carlborg
as code owners
Contributor
|
Thanks for your pull request, @WalterBright! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#10410" |
thewilsonator
approved these changes
Sep 16, 2019
Member
Author
|
I got the same Azure errors as #10409 Something gone wrong with Azure? |
Contributor
|
I think so. see also #10408 (comment) |
Member
Author
|
Any hope of getting Azure fixed? Who should I harangue? |
Contributor
|
see also dlang/druntime#2800 which should prevent future such events. But the root cause of the problem seems to be flakey stack stomping code interacting nastily with windows in conjunction with |
Member
|
Restarted failing checks, let's see how it goes |
Member
Author
|
ah, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refis the safer, more modern style.