Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Revert "core.thread refactor: osthread module"#2799

Merged
dlang-bot merged 1 commit intodlang:masterfrom
Geod24:revert-2689-osthread
Sep 17, 2019
Merged

Revert "core.thread refactor: osthread module"#2799
dlang-bot merged 1 commit intodlang:masterfrom
Geod24:revert-2689-osthread

Conversation

@Geod24
Copy link
Member

@Geod24 Geod24 commented Sep 17, 2019

Reverts #2689

Because it apparently broke DMD test suite.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @Geod24!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2799"

@Geod24
Copy link
Member Author

Geod24 commented Sep 17, 2019

CC @thewilsonator @baziotis

@Geod24
Copy link
Member Author

Geod24 commented Sep 17, 2019

@thewilsonator : Can we merge this ?

@dlang-bot dlang-bot merged commit 50888c7 into dlang:master Sep 17, 2019
@Geod24 Geod24 deleted the revert-2689-osthread branch September 17, 2019 05:40
@rainers
Copy link
Member

rainers commented Sep 17, 2019

A bit too late, but #2801 should fix the issue, too.

@thewilsonator
Copy link
Contributor

Thanks, but even if it does we, should enable the azure pipelines for druntime to test it anyway.

@baziotis
Copy link
Contributor

A bit too late, but #2801 should fix the issue, too.

TBH, I didn't have the time to look thoroughly what the problem was, but #2689 did not change any code. I see that yours does a small change. Which makes me think about how the problem arose in the first place and why it didn't happen with the previous.

@thewilsonator
Copy link
Contributor

Possibly slack layout, it should be pretty simple to revert this once the azure pipelines are set up for druntime.

@thewilsonator
Copy link
Contributor

@baziotis Azure pipelines are now set up, could you please reopen another PR. it seems that this can't be simply reverted due to merge conflicts.

@baziotis
Copy link
Contributor

baziotis commented Oct 3, 2019

Good! Yes, I assume tomorrow I will have time.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants