Revert "core.thread refactor: osthread module"#2799
Conversation
|
Thanks for your pull request, @Geod24! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2799" |
|
@thewilsonator : Can we merge this ? |
|
A bit too late, but #2801 should fix the issue, too. |
|
Thanks, but even if it does we, should enable the azure pipelines for druntime to test it anyway. |
TBH, I didn't have the time to look thoroughly what the problem was, but #2689 did not change any code. I see that yours does a small change. Which makes me think about how the problem arose in the first place and why it didn't happen with the previous. |
|
Possibly slack layout, it should be pretty simple to revert this once the azure pipelines are set up for druntime. |
|
@baziotis Azure pipelines are now set up, could you please reopen another PR. it seems that this can't be simply reverted due to merge conflicts. |
|
Good! Yes, I assume tomorrow I will have time. |
Reverts #2689
Because it apparently broke DMD test suite.