This repository was archived by the owner on Oct 12, 2022. It is now read-only.
fix issue 13821 - fiber + exception + win server 2012 failures#2801
Merged
dlang-bot merged 1 commit intodlang:masterfrom Sep 17, 2019
Merged
fix issue 13821 - fiber + exception + win server 2012 failures#2801dlang-bot merged 1 commit intodlang:masterfrom
dlang-bot merged 1 commit intodlang:masterfrom
Conversation
the Windows server exception chain validation fails because the initial exception entry is wrong in case the stack was aligned manually.
rainers
requested review from
Burgos,
MartinNowak and
PetarKirov
as code owners
Contributor
|
Thanks for your pull request, @rainers! Bugzilla references
|
thewilsonator
approved these changes
Sep 17, 2019
Geod24
reviewed
Sep 17, 2019
| pstack -= reserve; | ||
| *(cast(EXCEPTION_REGISTRATION*)pstack) = | ||
| EXCEPTION_REGISTRATION( sehChainEnd, finalHandler ); | ||
| auto pChainEnd = pstack; |
Member
Author
There was a problem hiding this comment.
Not really the style of this file.
Contributor
There was a problem hiding this comment.
Normally I'd disagree that that is a good reason not to do it, but the whole file is about to get a re-architect anyway, so it doesn't really matter.
This was referenced Oct 8, 2019
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the Windows server exception chain validation fails because the initial exception entry is wrong in case the stack was aligned manually.
See https://github.com/dlang/druntime/compare/master...rainers:issue13821?expand=1#diff-8bb12ed976acf0a5132e877ec5a01ea8L4717