Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

fix issue 13821 again#2823

Merged
thewilsonator merged 2 commits intodlang:masterfrom
rainers:redo_issue13821
Oct 11, 2019
Merged

fix issue 13821 again#2823
thewilsonator merged 2 commits intodlang:masterfrom
rainers:redo_issue13821

Conversation

@rainers
Copy link
Member

@rainers rainers commented Oct 8, 2019

This should fix the CI breakage, redoing #2801.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @rainers!

Bugzilla references

Auto-close Bugzilla Severity Description
13821 blocker fiber + exception + win server 2012 failures

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2823"

@dlang-bot dlang-bot added the Bug Fix Include reference to corresponding bugzilla issue label Oct 8, 2019
@rainers
Copy link
Member Author

rainers commented Oct 8, 2019

I have currently no idea why this still fails (it works in a Windows Server VM locally). So maybe reverting with #2822 could fix the builds sooner.

@rainers rainers force-pushed the redo_issue13821 branch 2 times, most recently from 154d104 to 1df0891 Compare October 10, 2019 21:11
azure: copy source files to ../druntime
@rainers
Copy link
Member Author

rainers commented Oct 10, 2019

I finally figured the problem:

  • druntime is checked out into a folder "s", not "druntime" as for example AppVeyor does.
  • the build script clones dmd into "../dmd"
  • dmd's installation/build script windows-visual-studio.sh/windows.sh is invoked
  • as no folder "../druntime" exists druntime/master is checked out
  • dmd's build and tests are run

So, the azure tests never actually tested the PR, but always master (or stable).

This should be fixed now by copying the source folder to "../druntime". There is still a wrong message [GIT_CLONE] Switched druntime to branch master in the log, but that has to be fixed in dmd's repo.

@thewilsonator
Copy link
Contributor

Auto-merge toggled on

@thewilsonator thewilsonator merged commit 726d4d3 into dlang:master Oct 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Bug Fix Include reference to corresponding bugzilla issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants