Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

copy dmd's azure pipelines#2800

Closed
thewilsonator wants to merge 1 commit intodlang:masterfrom
thewilsonator:azure-pipelines
Closed

copy dmd's azure pipelines#2800
thewilsonator wants to merge 1 commit intodlang:masterfrom
thewilsonator:azure-pipelines

Conversation

@thewilsonator
Copy link
Contributor

so that breakages like #2689 won't happen again.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @thewilsonator! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + druntime#2800"

@thewilsonator
Copy link
Contributor Author

This is currently just a direct copy of DMD's it will likely need be adapted. (e.g. It doesn't appear to be triggering on this PR).

cc @Geod24

@Geod24
Copy link
Member

Geod24 commented Sep 17, 2019

Yeah you probably need to configure something on Azure's side, for which you'll need @wilzbach .
And we should be dropping AppVeyor I suppose.

Copy link
Contributor

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of duplicating all these tedious files, it might be better to reuse at least the lib files to avoid more out of sync files.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants