Fix broken C++ headers and broken bootstrap builds#10477
Merged
ibuclaw merged 5 commits intodlang:masterfrom Oct 24, 2019
Merged
Fix broken C++ headers and broken bootstrap builds#10477ibuclaw merged 5 commits intodlang:masterfrom
ibuclaw merged 5 commits intodlang:masterfrom
Conversation
ibuclaw
added
Severity:Regression
ibuclaw
requested review from
Geod24,
MartinNowak and
wilzbach
as code owners
Contributor
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#10477" |
ibuclaw
force-pushed
the
fixcxxheaders
branch
3 times, most recently
from
031992c to
028e6f6
Compare
Geod24
approved these changes
Oct 13, 2019
Member
Geod24
left a comment
Geod24
left a comment
There was a problem hiding this comment.
Don't you want this to target stable though ?
Member
Author
gdc targets master. |
Member
|
But you are fixing a regression w.r.t. C++ mangling |
wilzbach
reviewed
Oct 15, 2019
Contributor
|
The master-stable branch off hasn't happened yet, so if this is merged into master today, it will be in stable too. |
ibuclaw
force-pushed
the
fixcxxheaders
branch
from
e640e3f to
74fb6db
Compare
Member
Author
|
Rebased against HEAD. |
PetarKirov
approved these changes
Oct 17, 2019
Geod24
reviewed
Oct 18, 2019
ibuclaw
force-pushed
the
fixcxxheaders
branch
from
74fb6db to
1b9c49c
Compare
ibuclaw
added
the
Merge:72h no objection -> merge
Reorder fields so that public/private parts are trivially grouped.
ibuclaw
force-pushed
the
fixcxxheaders
branch
from
1b9c49c to
e4f60f5
Compare
Member
Author
|
vibe.d failures are in no way related, I'll ignore for now... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To prevent bootstrap regressions from being silently introduced, the compiler used to build cxx-frontend has been switched from the host dmd to the target dmd.Edit: Removed this as is just a bit too involved, and doesn't play well with current auto-tester order (adds a dependency on druntime that isn't built yet).
All that's left are relevant fixes and testsuite code.