Skip to content

[stable] Cherry-pick C++ mangling regression fix from master#10527

Merged
wilzbach merged 1 commit intodlang:stablefrom
kinke:ref
Nov 3, 2019
Merged

[stable] Cherry-pick C++ mangling regression fix from master#10527
wilzbach merged 1 commit intodlang:stablefrom
kinke:ref

Conversation

@kinke
Copy link
Contributor

@kinke kinke commented Nov 1, 2019

From #10477; the regression was introduced in 2.088.1, so let's have 2.089.x fixed and not wait 2 more months for 2.090.x.

@kinke kinke requested review from Geod24 and ibuclaw as code owners November 1, 2019 12:28
@dlang-bot
Copy link
Contributor

dlang-bot commented Nov 1, 2019

Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#10527"

@kinke kinke changed the base branch from master to stable November 1, 2019 12:29
@PetarKirov PetarKirov added Merge:auto-merge Feature:extern (C/C++/Obj-C) interfacing to C, C++, Objective-C code labels Nov 1, 2019
@kinke
Copy link
Contributor Author

kinke commented Nov 3, 2019

Please merge before v2.089.0 final [my 3 current DMD PRs all fail CI for spurious reasons].

Edit: Oh, already too late, been tagged 7 hours ago. :/

@PetarKirov
Copy link
Member

@kinke When you (force) push dlang-bot removes the auto-merge label. Please ping us as soon as you do this, so we can add it back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:extern (C/C++/Obj-C) interfacing to C, C++, Objective-C code Merge:auto-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants