Skip to content

build.d: Move install from posix.mak#10670

Merged
dlang-bot merged 1 commit intodlang:masterfrom
MoonlightSentinel:install
Dec 31, 2019
Merged

build.d: Move install from posix.mak#10670
dlang-bot merged 1 commit intodlang:masterfrom
MoonlightSentinel:install

Conversation

@MoonlightSentinel
Copy link
Copy Markdown
Contributor

@MoonlightSentinel MoonlightSentinel commented Dec 14, 2019

470c402 fixes install-copy omitting the configuration file (dmd.conf / sc.ini) and extends it for other OS to make it re-useable.
470c402 then renames 'install-copy' to install and adds 'install-copy' as a legacy alias.

TODO (inconsistencies between windows/posix):

  • (DMD)/src/posix.mak omits dmd's sources, should it copy them like win32.mak currently does?,
  • (DMD)/posix.mak includes docs and samples, should windows have this as well?

@dlang-bot
Copy link
Copy Markdown
Contributor

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#10670"

@MoonlightSentinel MoonlightSentinel force-pushed the install branch 4 times, most recently from 9f95e7e to 7cfd906 Compare December 21, 2019 16:06
@thewilsonator
Copy link
Copy Markdown
Contributor

Is this good to go?

@MoonlightSentinel
Copy link
Copy Markdown
Contributor Author

The first commit is ready IMO but I would prefer some feedback from @wilzbach and @marler8997 on how to deal with install and install-copy (because they have the same usecase but copy different files).

Could submit the first commit in another PR.

@MoonlightSentinel
Copy link
Copy Markdown
Contributor Author

See #10703

@marler8997
Copy link
Copy Markdown
Contributor

@MoonlightSentinel I think now I'm mostly satisfied with the state of build.d, so I'm less motivated to work on it now. I'll let you handle the install targets and do what you think is best. I don't see any issues with my quick glance at the changes.

Merges install and install-copy while keeping the latter as a legacy alias.

Note that 'make -f posix.mak install' will now copy the source files like
'make -f winXX.mak install' already did.
@dlang-bot dlang-bot merged commit dada1fd into dlang:master Dec 31, 2019
@MoonlightSentinel MoonlightSentinel deleted the install branch January 11, 2020 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants