build.d: Move install from posix.mak#10670
Conversation
|
Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#10670" |
9f95e7e to
7cfd906
Compare
|
Is this good to go? |
|
The first commit is ready IMO but I would prefer some feedback from @wilzbach and @marler8997 on how to deal with Could submit the first commit in another PR. |
7cfd906 to
107da20
Compare
|
See #10703 |
|
@MoonlightSentinel I think now I'm mostly satisfied with the state of |
Merges install and install-copy while keeping the latter as a legacy alias. Note that 'make -f posix.mak install' will now copy the source files like 'make -f winXX.mak install' already did.
107da20 to
724f214
Compare
470c402 fixes
install-copyomitting the configuration file (dmd.conf/sc.ini) and extends it for other OS to make it re-useable.470c402 then renames 'install-copy' to
installand adds 'install-copy' as a legacy alias.TODO (inconsistencies between windows/posix):
(DMD)/src/posix.makomits dmd's sources, should it copy them likewin32.makcurrently does?,(DMD)/posix.makincludes docs and samples, should windows have this as well?