(Fix #20662) Set the DMD binary as executable#10889
Merged
Conversation
Contributor
|
Thanks for your pull request and interest in making D better, @ErnyTech! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#10889" |
ghost
mentioned this pull request
The dmd binary must have permission to be executable otherwise it would be impossible to launch it without manually setting permissions. This patch sets the 644 permission by default for all the other files installed through installRelativeFiles while the 755 permissions will be set for the dmd binary. This fixes the issue #20662
Author
|
The alternative would be to copy the files while preserving the attributes, specifically pass this "Yes.preserveAttributes" to std.copy |
ghost
changed the title
thewilsonator
approved these changes
Mar 10, 2020
ghost
pushed a commit
to dlang-snaps/dmd.snap
that referenced
this pull request
Mar 14, 2020
https://dlang.org/changelog/2.091.0.html https://github.com/dlang/dmd/releases/tag/v2.091.0 This version includes an upstream patch (dlang/dmd#10889) not present in DMD 2.091.0 but which will be included in DMD 2.091.1 This patch is necessary to resolve a regression present in DMD 2.091.0 which would make the snap package unusable, for information: https://issues.dlang.org/show_bug.cgi?id=20662
ghost
pushed a commit
to dlang-snaps/dmd.snap
that referenced
this pull request
Mar 14, 2020
https://dlang.org/changelog/2.091.0.html https://github.com/dlang/dmd/releases/tag/v2.091.0 This version includes an upstream patch (dlang/dmd#10889) not present in DMD 2.091.0 but which will be included in DMD 2.091.1 This patch is necessary to resolve a regression present in DMD 2.091.0 which would make the snap package unusable, for information: https://issues.dlang.org/show_bug.cgi?id=20662
ghost
mentioned this pull request
ghost
pushed a commit
to dlang-snaps/dmd.snap
that referenced
this pull request
Apr 9, 2020
https://dlang.org/changelog/2.091.0.html https://github.com/dlang/dmd/releases/tag/v2.091.0 This version includes an upstream patch (dlang/dmd#10889) not present in DMD 2.091.0 but which will be included in DMD 2.091.1 This patch is necessary to resolve a regression present in DMD 2.091.0 which would make the snap package unusable, for information: https://issues.dlang.org/show_bug.cgi?id=20662
Member
|
Oops. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The dmd binary must have permission to be executable otherwise it would be
impossible to launch it without manually setting permissions.
This patch sets the 644 permission by default for all the other files installed
through installRelativeFiles while the 755 permissions will be set for the dmd binary.
This fixes a regression caused by the PR #10670