Merged
Conversation
Contributor
|
Thanks for your pull request and interest in making D better, @kinke! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#10802" |
thewilsonator
approved these changes
Feb 19, 2020
wilzbach
approved these changes
Feb 19, 2020
Apparently introduced by dlang#9478; the placeholder was already used in 4736cf4 and later restored another time in 4e8d1cd.
Contributor
Author
|
I've added a little check for that placeholder, in the hopes of never seeing this regress again (it has been introduced in 2013, #1699). |
WebDrake
added a commit
to WebDrake/ldc2.snap
that referenced
this pull request
Feb 19, 2020
Using `chown` to set `root` as the owner of `/` was suggested on the snapcraft forums, and appears to work for others: https://forum.snapcraft.io/t/permissions-problem-using-snapcraft-in-azure-pipelines/13258/14 Unfortunately this exposes a nasty regression in the DMD testsuite: the `ddocYear` test-case hard-encodes an expected year, when it should be a placeholder that gets replaced with the year when the build takes place. We can work around this by using `sed` to replace the hardcoded year. It will be necessary to update this workaround for LDC 1.20.x (when the hardcoded year switches from 2019 to 2020), and it should be possible to remove the workaround entirely with LDC 1.21, thanks to an upstream fix that should land in the next DMD frontend release: dlang/dmd#10802
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Apparently introduced by #9478; the placeholder was already used in 4736cf4 and later restored another time in 4e8d1cd.