Support markdown-style quote blocks#9478
Conversation
|
Thanks for your pull request and interest in making D better, @dgileadi! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#9478" |
d79bdf5 to
0604adf
Compare
| size_t delta = 0; | ||
| delta += MarkdownList.endAllNestedLists(buf, iLineStart, nestedLists); | ||
| delta += endAllMarkdownQuotes(buf, iLineStart, quoteLevel, quoteMacroLevel); | ||
| i += delta; |
There was a problem hiding this comment.
Looks very similar to the code above. Can this be extracted somehow, or will that just make it more complicated?
There was a problem hiding this comment.
I made a function that combines the two, and hopefully addresses the quoteMacroLevel comment as well.
|
It would be nice with a screenshot of how this looks rendered. I suggest you include screenshots in future PRs as well. |
0604adf to
96c67ea
Compare
|
Is this enabled by default or enabled using some flag? |
Like all the markdown features, it's enabled by the |
Right, I missed that. 👍. |
|
Anything else holding this up? |
Apparently introduced by dlang#9478; the placeholder was already used in 4736cf4 and later restored another time in 4e8d1cd.
Apparently introduced by dlang#9478; the placeholder was already used in 4736cf4 and later restored another time in 4e8d1cd.
Screenshot:
Proposed documentation:
Quotes
Documentation may include a section of quoted material by prefixing each line of the section with a
>. Quotes may include headings, lists, embedded code, etc.Lines of text that directly follow a quoted line are considered part of the quote: