Fix issue 20809 - return statement might access memory from destructed temporary#11214
Closed
welkam wants to merge 263 commits intodlang:stablefrom
Closed
Fix issue 20809 - return statement might access memory from destructed temporary#11214welkam wants to merge 263 commits intodlang:stablefrom
welkam wants to merge 263 commits intodlang:stablefrom
Conversation
…s-live-function getFunctionAttributes supports live function attribute merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
This was an issue on other platforms, as CC might be gcc, cc, clang, sometimes even c++, g++ or clang++. Instead of dealing with that, just provide our own wrapper script which writes the arguments passed to it, and voila.
Rewrite test6952 to be independent of the CC variable merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
add TYrestrictPtr to backend merged-on-behalf-of: Iain Buclaw <ibuclaw@gdcproject.org>
For the case of nested or non-trivial structs, there's no point checking all fields, the answer is still no.
dmd.dstruct: Return false immediately after setting StructPOD.no merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
…t need destruction
Better compiler error message merged-on-behalf-of: unknown
fix Issue 20771, 20772, 20775 disallow passing non-trivially copyable types as variadic arguments merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
elem.d: replace p/len with str merged-on-behalf-of: Mathias LANG <pro.mathias.lang@gmail.com>
fix Issue 20747 - @LiVe tracking of non-pointer owners not done merged-on-behalf-of: Atila Neves <atilaneves@users.noreply.github.com>
Detect and shortcut AliasSeq templates merged-on-behalf-of: Atila Neves <atilaneves@users.noreply.github.com>
`$r:<regex>$` matches the output against the given regex
Don't use explicit mangles for builtins merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
Trim excessive zeros when printing integral compile-time reals merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
merge stable merged-on-behalf-of: Walter Bright <WalterBright@users.noreply.github.com>
gloop now recycles memory instead of free/malloc merged-on-behalf-of: Mathias LANG <pro.mathias.lang@gmail.com>
cxx-unittest: Update C++ baseline support to C++11 merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
add scope varargs support to ob merged-on-behalf-of: Walter Bright <WalterBright@users.noreply.github.com>
Previously, a regex used to match the result of __DATE__ would fail on the 1st through 9th of a month, because it expected one space between the month and day instead of two.
Make tests pass on single-digit days of month
… prefixed with a non-standard "ERROR:" So that dmd developpers working with IDE can click the first message.
fix issue 20824 - error messages generated by dmd build script can be… merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
De-virtualize toBasetype() so it is inlineable merged-on-behalf-of: Walter Bright <WalterBright@users.noreply.github.com>
Fix tag generation on posix merged-on-behalf-of: Florian <moonlightsentinel@disroot.org>
Port runnable/paranoia.sh to D merged-on-behalf-of: Nicholas Wilson <thewilsonator@users.noreply.github.com>
welkam
requested review from
Geod24,
MartinNowak,
RazvanN7,
WalterBright,
andralex,
ibuclaw,
jacob-carlborg,
rainers and
wilzbach
as code owners
Contributor
|
Thanks for your pull request and interest in making D better, @welkam! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#11214" |
Contributor
Author
|
Cmon git. I wanted to pull one commit not millions |
Contributor
|
You don’t need to open another pull request, you can fix & force push your branch. Pro Git is a worthwhile read. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing this issue. I realized that I bit more than I can chew on this one.
What this patch provides:
The problems:
Solutions:
A. Some one uses this to kickstart a new pull request.
B. Some one helps with guidance because im not confident that I can make required changes and think of all possible cases to make sure it doesnt break something else.