Disable Windows builds on the auto-tester - replace with Azure pipelines#11653
Disable Windows builds on the auto-tester - replace with Azure pipelines#11653wilzbach merged 4 commits intodlang:masterfrom
Conversation
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#11653" |
| @@ -6,16 +6,17 @@ defaulttarget: | |||
| cd .. | |||
|
|
|||
| auto-tester-build: | |||
There was a problem hiding this comment.
I assume these changes will break the makefile patching done on the auto-tester?
If that is the case:
- Remove these changes
- Forward
MAKECMDGOALStotest/Makefileand do an early exit there
There was a problem hiding this comment.
Yeah I thought the windows 64 diff had been disabled, but I was wrong :/
https://github.com/braddr/at-client/blob/master/src/do_fixup.sh#L21
cb62b03 to
4dc59f1
Compare
43d191c to
288491a
Compare
So it turns out that the |
288491a to
f30597f
Compare
f30597f to
7f05a44
Compare
.azure-pipelines/windows.sh
Outdated
| # do not run runnable_cxx or unit_tests with older bootstrap compilers | ||
| targets=("compilable" "fail_compilation" "runnable" "dshell") | ||
| fi | ||
| ./run --environment --jobs=$N "${targets[@]}" ARGS="-O -inline -g" MODEL="$MODEL" |
There was a problem hiding this comment.
Note that the auto-tester also includes -release in ARGS
c42790e to
2abd44b
Compare
2abd44b to
8f4bee9
Compare
|
FYI: this is green on all CIs now 🌮 (except for the auto-tester Windows machines. It requires dlang/druntime#3203 and dlang/phobos#7613 for auto-tester to fully skip Windows build - these three PRs depend on each other) |
|
This won't auto-merge as it is interlocked with druntime and Phobos. I will manually merge this and the respective PRs in druntime and Phobos. |
We wanted to switch away from the auto-tester for a long time now. However, finding good alternatives has always been tricky and it often was blocked on e.g. a replacement for the FreeBSD testing. Now that the Windows machines are randomly failing again and no one knows why and it's super hard to debug, I think it's more than overdue to start the migration. Over the last months (years?) we have made good experiences with Azure pipelines and they offer 10 concurrent builds for open source projects. It's a stable infrastructure and upgrading to e.g. a newer visual studio build is as easy as changing the VM Image. LDC has been using Azure Pipelines for their Windows testing successfully for a long time as well.
This PR starts to disable the Windows builds on the auto-tester (auto-tester will still fail as the Makefiles need to be disabled on druntime + Phobos too) and adds two Windows builds to Azure with our bootstrapping compiler version (2.079.0).
The other bootstrap builds (Linux, FreeBSD, OSX) can be moved to other CIs later, but for now we want to unblock the broken CI checks.
CC @MoonlightSentinel @andralex @PetarKirov