Disable Windows tests on auto-tester#11667
Merged
MoonlightSentinel merged 2 commits intodlang:masterfrom Sep 2, 2020
Merged
Conversation
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#11667" |
wilzbach
commented
Sep 1, 2020
win32.mak
Outdated
| #cd .. | ||
| #cd samples | ||
| #gmake -f win32.mak DMD=..\src\dmd.exe MODEL=$(MODEL) "LIB=..\..\phobos;$(LIB)" \ | ||
| # "DFLAGS=-I..\..\druntime\import -I..\..\phobos -m$(MODEL)" |
Contributor
Author
There was a problem hiding this comment.
Should we
- integrate this into
run.d - hack into one of Azure pipelines
- drop the samples (they are very old)
Contributor
There was a problem hiding this comment.
Probably best to drop them or move them into druntime/phobs (they primarily "test" libraries AFAICT)
wilzbach
force-pushed
the
disable-windows-64
branch
from
573e6d9 to
61a5bb6
Compare
Contributor
Author
|
Adding auto-merge as otherwise all other PRs will be broken. |
MoonlightSentinel
approved these changes
Sep 1, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that the
auto-tester-testtarget is unused, butallis called :/See: #11653