Translate _d_newitem{U,T,iT} to a template#14664
Merged
RazvanN7 merged 1 commit intodlang:masterfrom May 12, 2023
Merged
Conversation
Contributor
|
Thanks for your pull request, @teodutu! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#14664" |
Member
|
tests seem to be failing. |
teodutu
force-pushed
the
template-_d_newitemT
branch
from
97942db to
2d9def4
Compare
Member
Author
|
Yeah @UplinkCoder, |
teodutu
commented
Dec 2, 2022
teodutu
force-pushed
the
template-_d_newitemT
branch
from
2d9def4 to
934d4a3
Compare
Member
Author
|
|
teodutu
force-pushed
the
template-_d_newitemT
branch
from
934d4a3 to
c175c64
Compare
Member
Author
|
I managed to avoid https://issues.dlang.org/show_bug.cgi?id=23650 by avoiding the lowering altogether inside |
teodutu
force-pushed
the
template-_d_newitemT
branch
9 times, most recently
from
d3f3c67 to
1d245f5
Compare
Member
|
@teodutu please rebase |
teodutu
force-pushed
the
template-_d_newitemT
branch
from
1d245f5 to
eea4973
Compare
teodutu
force-pushed
the
template-_d_newitemT
branch
from
eea4973 to
8ccce9e
Compare
Member
Author
|
Done @PetarKirov. I'll look into the traceGC errors later this week. |
teodutu
force-pushed
the
template-_d_newitemT
branch
2 times, most recently
from
206e85b to
5400302
Compare
RazvanN7
reviewed
May 10, 2023
teodutu
force-pushed
the
template-_d_newitemT
branch
from
5400302 to
fedf8e5
Compare
Contributor
|
cc @dkorpel @PetarKirov this seems to be green now. |
RazvanN7
approved these changes
May 10, 2023
RazvanN7
added
the
Merge:72h no objection -> merge
teodutu
force-pushed
the
template-_d_newitemT
branch
from
fedf8e5 to
7077de1
Compare
Member
Author
|
Done @dkorpel. Take another look when you can. |
teodutu
force-pushed
the
template-_d_newitemT
branch
3 times, most recently
from
207c374 to
1e21a7c
Compare
This makes the following changes:
- Replace `_d_newitem{U,T,iT}` with a template `_d_newitemT` that
allocates memory for the new `struct` and performs the required
initialisation
- Move lowering call to `_d_newitemT` from e2ir.d to expressionsem.d
- Add `lowering` field to `NewExp` that contains the lowered call and
use it in e2ir.d
- Remove `_d_newitem{,i}T` from rt.lifetime
Signed-off-by: Teodor Dutu <teodor.dutu@gmail.com>
teodutu
force-pushed
the
template-_d_newitemT
branch
from
1e21a7c to
960326c
Compare
dkorpel
approved these changes
May 12, 2023
Contributor
dkorpel
left a comment
dkorpel
left a comment
There was a problem hiding this comment.
I thought you were going to forward Unqual!T in druntime, but unqualifying in the compiler works too.
nybzmr
added a commit
to nybzmr/dmd
that referenced
this pull request
Mar 19, 2025
…EMIT, TRACENEWITEMT and TRACENEWITEMIT
thewilsonator
pushed a commit
that referenced
this pull request
Mar 19, 2025
* Remove RTLSYM for Translation PR #15819: Removed NEWARRAYMITX, NEWARRAYMITX, TRACENEWARRAYMTX and TRACENEWARRAYMITX * Remove RTLSYM for Translation PR #15299: Removed NEWARRAYT, NEWARRAYIT, TRACENEWARRAYT and TRACENEWARRAYIT * Remove RTLSYM for Translation PR #14837: Removed NEWCLASS, TRACENEWCLASS * Remove RTLSYM for Translation PR #14664: Removed NEWITEMT, NEWITEMIT, TRACENEWITEMT and TRACENEWITEMIT * Remove RTLSYM for Translation PR #14550: Removed ARRAYCATNTX, ARRAYCATT, TRACEARRAYCATNTX and TRACEARRAYCATT * Remove RTLSYM for Translation PR #14382: Removed ARRAYSETASSIGN * Remove RTLSYM for Translation PR #14310: Removed ARRAYASSIGN * Remove RTLSYM for Translation PR #13495: Removed ARRAYAPPENDT, ARRAYAPPENDCTX, TRACEARRAYAPPENDT and TRACEARRAYAPPENDCTX
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contributes to dlang/project-ideas#25 and makes the following changes:
_d_newitem{U,T,iT}with a template_d_newitemTthat allocates memory for the newstructand performs the required initialisation_d_newitemTfrom e2ir.d to expressionsem.dloweringfield toNewExpthat contains the lowered call and use it in e2ir.d_d_newitem{,i}Tfrom rt.lifetime.d