Remove Unused RTLSYMs from DMD#21032
Conversation
…EWARRAYMITX, TRACENEWARRAYMTX and TRACENEWARRAYMITX
…RRAYIT, TRACENEWARRAYT and TRACENEWARRAYIT
…EMIT, TRACENEWITEMT and TRACENEWITEMIT
…RAYCATT, TRACEARRAYCATNTX and TRACEARRAYCATT
…RRAYAPPENDCTX, TRACEARRAYAPPENDT and TRACEARRAYAPPENDCTX
|
Thanks for your pull request and interest in making D better, @nybzmr! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#21032" |
| @@ -326,26 +326,17 @@ void toTraceGC(ref IRState irs, elem* e, Loc loc) | |||
| { | |||
| static immutable RTLSYM[2][25] map = | |||
There was a problem hiding this comment.
This 25 can be lowered to 9, or completely removed
There was a problem hiding this comment.
Thanks for the suggestion! I'll check how many elements are actually used and update the size accordingly. If it's possible to remove the explicit size altogether, I'll do that as well.
This PR removes several unused RTLSYMs that became obsolete due to past backend refactorings (mainly from translation PRs by @teodutu). These symbols were previously used in e2ir.d, but their references have been removed, making them redundant.
✔️ Cleaned up
rtlsym.d,drtlsym.d, e2ir.d mappings and other related files.✔️ Ensured that tracing GC hooks (
toTraceGC) are updated accordingly.@teodutu @dlang/compiler-team