Skip to content

Remove Unused RTLSYMs from DMD#21032

Merged
thewilsonator merged 8 commits intodlang:masterfrom
nybzmr:rtlsym-removals
Mar 19, 2025
Merged

Remove Unused RTLSYMs from DMD#21032
thewilsonator merged 8 commits intodlang:masterfrom
nybzmr:rtlsym-removals

Conversation

@nybzmr
Copy link
Contributor

@nybzmr nybzmr commented Mar 19, 2025

This PR removes several unused RTLSYMs that became obsolete due to past backend refactorings (mainly from translation PRs by @teodutu). These symbols were previously used in e2ir.d, but their references have been removed, making them redundant.
✔️ Cleaned up rtlsym.d, drtlsym.d, e2ir.d mappings and other related files.
✔️ Ensured that tracing GC hooks (toTraceGC) are updated accordingly.

@teodutu @dlang/compiler-team

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @nybzmr! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#21032"

@thewilsonator thewilsonator merged commit cfefcdd into dlang:master Mar 19, 2025
42 checks passed
@@ -326,26 +326,17 @@ void toTraceGC(ref IRState irs, elem* e, Loc loc)
{
static immutable RTLSYM[2][25] map =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This 25 can be lowered to 9, or completely removed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! I'll check how many elements are actually used and update the size accordingly. If it's possible to remove the explicit size altogether, I'll do that as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants