Skip to content

Remove Unused RTLSYMs from DMD #21032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thewilsonator merged 8 commits into from
Mar 19, 2025
Merged

Remove Unused RTLSYMs from DMD #21032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e6594ee
Remove RTLSYM for Translation PR #15819: Removed NEWARRAYMITX, NEWARR…
nybzmr Mar 19, 2025
ee7bf97
Remove RTLSYM for Translation PR #15299: Removed NEWARRAYT, NEWARRAYI…
nybzmr Mar 19, 2025
5b41516
Remove RTLSYM for Translation PR #14837: Removed NEWCLASS, TRACENEWCLASS
nybzmr Mar 19, 2025
6bcbfa7
Remove RTLSYM for Translation PR #14664: Removed NEWITEMT, NEWITEMIT,…
nybzmr Mar 19, 2025
4de3551
Remove RTLSYM for Translation PR #14550: Removed ARRAYCATNTX, ARRAYCA…
nybzmr Mar 19, 2025
912ff38
Remove RTLSYM for Translation PR #14382: Removed ARRAYSETASSIGN
nybzmr Mar 19, 2025
9847fb9
Remove RTLSYM for Translation PR #14310: Removed ARRAYASSIGN
nybzmr Mar 19, 2025
0c61038
Remove RTLSYM for Translation PR #13495: Removed ARRAYAPPENDT, ARRAYA…
nybzmr Mar 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 1 addition & 22 deletions compiler/src/dmd/backend/drtlsym.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,13 +103,7 @@ Symbol* getRtlsym(RTLSYM i) @trusted
case RTLSYM.MEMSETDOUBLE: symbolz(ps,FL.func,FREGSAVED,"_memsetDouble", 0, t); break;
case RTLSYM.MEMSETSIMD: symbolz(ps,FL.func,FREGSAVED,"_memsetSIMD",0, t); break;
case RTLSYM.MEMSETN: symbolz(ps,FL.func,FREGSAVED,"_memsetn", 0, t); break;
case RTLSYM.NEWCLASS: symbolz(ps,FL.func,FREGSAVED,"_d_newclass", 0, t); break;
case RTLSYM.NEWTHROW: symbolz(ps,FL.func,FREGSAVED,"_d_newThrowable", 0, t); break;
case RTLSYM.NEWARRAYT: symbolz(ps,FL.func,FREGSAVED,"_d_newarrayT", 0, t); break;
case RTLSYM.NEWARRAYIT: symbolz(ps,FL.func,FREGSAVED,"_d_newarrayiT", 0, t); break;
case RTLSYM.NEWITEMT: symbolz(ps,FL.func,FREGSAVED,"_d_newitemT", 0, t); break;
case RTLSYM.NEWITEMIT: symbolz(ps,FL.func,FREGSAVED,"_d_newitemiT", 0, t); break;
case RTLSYM.NEWARRAYMITX: symbolz(ps,FL.func,FREGSAVED,"_d_newarraymiTX", 0, t); break;
case RTLSYM.ARRAYLITERALTX: symbolz(ps,FL.func,FREGSAVED,"_d_arrayliteralTX", 0, t); break;
case RTLSYM.ASSOCARRAYLITERALTX: symbolz(ps,FL.func,FREGSAVED,"_d_assocarrayliteralTX", 0, t); break;
case RTLSYM.CALLFINALIZER: symbolz(ps,FL.func,FREGSAVED,"_d_callfinalizer", 0, t); break;
Expand All @@ -120,18 +114,13 @@ Symbol* getRtlsym(RTLSYM i) @trusted
case RTLSYM.CLASS_CAST: symbolz(ps,FL.func,FREGSAVED,"_d_class_cast", 0, t); break;
case RTLSYM.INTERFACE_CAST: symbolz(ps,FL.func,FREGSAVED,"_d_interface_cast", 0, t); break;
case RTLSYM.ARRAYCATT: symbolz(ps,FL.func,FREGSAVED,"_d_arraycatT", 0, t); break;
case RTLSYM.ARRAYCATNTX: symbolz(ps,FL.func,FREGSAVED,"_d_arraycatnTX", 0, t); break;
case RTLSYM.ARRAYAPPENDT: symbolz(ps,FL.func,FREGSAVED,"_d_arrayappendT", 0, t); break;
case RTLSYM.ARRAYAPPENDCTX: symbolz(ps,FL.func,FREGSAVED,"_d_arrayappendcTX", 0, t); break;
case RTLSYM.ARRAYAPPENDCD: symbolz(ps,FL.func,FREGSAVED,"_d_arrayappendcd", 0, t); break;
case RTLSYM.ARRAYAPPENDWD: symbolz(ps,FL.func,FREGSAVED,"_d_arrayappendwd", 0, t); break;
case RTLSYM.ARRAYSETLENGTHT: symbolz(ps,FL.func,FREGSAVED,"_d_arraysetlengthT", 0, t); break;
case RTLSYM.ARRAYSETLENGTHIT: symbolz(ps,FL.func,FREGSAVED,"_d_arraysetlengthiT", 0, t); break;
case RTLSYM.ARRAYCOPY: symbolz(ps,FL.func,FREGSAVED,"_d_arraycopy", 0, t); break;
case RTLSYM.ARRAYASSIGN: symbolz(ps,FL.func,FREGSAVED,"_d_arrayassign", 0, t); break;
case RTLSYM.ARRAYASSIGN_R: symbolz(ps,FL.func,FREGSAVED,"_d_arrayassign_r", 0, t); break;
case RTLSYM.ARRAYASSIGN_L: symbolz(ps,FL.func,FREGSAVED,"_d_arrayassign_l", 0, t); break;
case RTLSYM.ARRAYSETASSIGN: symbolz(ps,FL.func,FREGSAVED,"_d_arraysetassign", 0, t); break;
case RTLSYM.ARRAYEQ2: symbolz(ps,FL.func,FREGSAVED,"_adEq2", 0, t); break;

/* Associative Arrays https://github.com/dlang/dmd/blob/master/druntime/src/rt/aaA.d */
Expand Down Expand Up @@ -173,21 +162,11 @@ Symbol* getRtlsym(RTLSYM i) @trusted
case RTLSYM.TRACE_EPI_N: symbolz(ps,FL.func,ALLREGS|mBP|mES,"_trace_epi_n",0,tstrace); break;
case RTLSYM.TRACE_EPI_F: symbolz(ps,FL.func,ALLREGS|mBP|mES,"_trace_epi_f",0,tstrace); break;

case RTLSYM.TRACENEWCLASS: symbolz(ps,FL.func,FREGSAVED,"_d_newclassTrace", 0, t); break;
case RTLSYM.TRACENEWARRAYT: symbolz(ps,FL.func,FREGSAVED,"_d_newarrayTTrace", 0, t); break;
case RTLSYM.TRACENEWARRAYIT: symbolz(ps,FL.func,FREGSAVED,"_d_newarrayiTTrace", 0, t); break;
case RTLSYM.TRACENEWARRAYMTX: symbolz(ps,FL.func,FREGSAVED,"_d_newarraymTXTrace", 0, t); break;
case RTLSYM.TRACENEWARRAYMITX: symbolz(ps,FL.func,FREGSAVED,"_d_newarraymiTXTrace", 0, t); break;
case RTLSYM.TRACENEWITEMT: symbolz(ps,FL.func,FREGSAVED,"_d_newitemTTrace", 0, t); break;
case RTLSYM.TRACENEWITEMIT: symbolz(ps,FL.func,FREGSAVED,"_d_newitemiTTrace", 0, t); break;

case RTLSYM.TRACECALLFINALIZER: symbolz(ps,FL.func,FREGSAVED,"_d_callfinalizerTrace", 0, t); break;
case RTLSYM.TRACECALLINTERFACEFINALIZER: symbolz(ps,FL.func,FREGSAVED,"_d_callinterfacefinalizerTrace", 0, t); break;
case RTLSYM.TRACEARRAYLITERALTX: symbolz(ps,FL.func,FREGSAVED,"_d_arrayliteralTXTrace", 0, t); break;
case RTLSYM.TRACEASSOCARRAYLITERALTX: symbolz(ps,FL.func,FREGSAVED,"_d_assocarrayliteralTXTrace", 0, t); break;
case RTLSYM.TRACEARRAYCATT: symbolz(ps,FL.func,FREGSAVED,"_d_arraycatTTrace", 0, t); break;
case RTLSYM.TRACEARRAYCATNTX: symbolz(ps,FL.func,FREGSAVED,"_d_arraycatnTXTrace", 0, t); break;
case RTLSYM.TRACEARRAYAPPENDT: symbolz(ps,FL.func,FREGSAVED,"_d_arrayappendTTrace", 0, t); break;
case RTLSYM.TRACEARRAYAPPENDCTX: symbolz(ps,FL.func,FREGSAVED,"_d_arrayappendcTXTrace", 0, t); break;
case RTLSYM.TRACEARRAYAPPENDCD: symbolz(ps,FL.func,FREGSAVED,"_d_arrayappendcdTrace", 0, t); break;
case RTLSYM.TRACEARRAYAPPENDWD: symbolz(ps,FL.func,FREGSAVED,"_d_arrayappendwdTrace", 0, t); break;
case RTLSYM.TRACEARRAYSETLENGTHT: symbolz(ps,FL.func,FREGSAVED,"_d_arraysetlengthTTrace", 0, t); break;
Expand Down
25 changes: 2 additions & 23 deletions compiler/src/dmd/backend/rtlsym.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,8 @@ enum RTLSYM
MEMSETDOUBLE,
MEMSETSIMD,
MEMSETN,
NEWCLASS,
NEWTHROW,
NEWARRAYT,
NEWARRAYIT,
NEWITEMT,
NEWITEMIT,
NEWARRAYMTX,
NEWARRAYMITX,

ARRAYLITERALTX,
ASSOCARRAYLITERALTX,
CALLFINALIZER,
Expand All @@ -65,18 +59,13 @@ enum RTLSYM
CLASS_CAST,
INTERFACE_CAST,
ARRAYCATT,
ARRAYCATNTX,
ARRAYAPPENDT,
ARRAYAPPENDCTX,
ARRAYAPPENDCD,
ARRAYAPPENDWD,
ARRAYSETLENGTHT,
ARRAYSETLENGTHIT,
ARRAYCOPY,
ARRAYASSIGN,
ARRAYASSIGN_R,
ARRAYASSIGN_L,
ARRAYSETASSIGN,
ARRAYEQ2,
AANEW,
AAEQUAL,
Expand Down Expand Up @@ -116,21 +105,11 @@ enum RTLSYM
TRACE_EPI_N,
TRACE_EPI_F,

TRACENEWCLASS,
TRACENEWARRAYT,
TRACENEWARRAYIT,
TRACENEWARRAYMTX,
TRACENEWARRAYMITX,
TRACENEWITEMT,
TRACENEWITEMIT,

TRACECALLFINALIZER,
TRACECALLINTERFACEFINALIZER,
TRACEARRAYLITERALTX,
TRACEASSOCARRAYLITERALTX,
TRACEARRAYCATT,
TRACEARRAYCATNTX,
TRACEARRAYAPPENDT,
TRACEARRAYAPPENDCTX,
TRACEARRAYAPPENDCD,
TRACEARRAYAPPENDWD,
TRACEARRAYSETLENGTHT,
Expand Down
11 changes: 1 addition & 10 deletions compiler/src/dmd/e2ir.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,26 +326,17 @@ void toTraceGC(ref IRState irs, elem* e, Loc loc)
{
static immutable RTLSYM[2][25] map =
Copy link
Contributor

@dkorpel dkorpel Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This 25 can be lowered to 9, or completely removed

Copy link
Contributor Author

@nybzmr nybzmr Mar 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion! I'll check how many elements are actually used and update the size accordingly. If it's possible to remove the explicit size altogether, I'll do that as well.

[
[ RTLSYM.NEWCLASS, RTLSYM.TRACENEWCLASS ],
[ RTLSYM.NEWITEMT, RTLSYM.TRACENEWITEMT ],
[ RTLSYM.NEWITEMIT, RTLSYM.TRACENEWITEMIT ],
[ RTLSYM.NEWARRAYT, RTLSYM.TRACENEWARRAYT ],
[ RTLSYM.NEWARRAYIT, RTLSYM.TRACENEWARRAYIT ],
[ RTLSYM.NEWARRAYMITX, RTLSYM.TRACENEWARRAYMITX ],

[ RTLSYM.CALLFINALIZER, RTLSYM.TRACECALLFINALIZER ],
[ RTLSYM.CALLINTERFACEFINALIZER, RTLSYM.TRACECALLINTERFACEFINALIZER ],

[ RTLSYM.ARRAYLITERALTX, RTLSYM.TRACEARRAYLITERALTX ],
[ RTLSYM.ASSOCARRAYLITERALTX, RTLSYM.TRACEASSOCARRAYLITERALTX ],

[ RTLSYM.ARRAYCATT, RTLSYM.TRACEARRAYCATT ],
[ RTLSYM.ARRAYCATNTX, RTLSYM.TRACEARRAYCATNTX ],

[ RTLSYM.ARRAYAPPENDCD, RTLSYM.TRACEARRAYAPPENDCD ],
[ RTLSYM.ARRAYAPPENDWD, RTLSYM.TRACEARRAYAPPENDWD ],
[ RTLSYM.ARRAYAPPENDT, RTLSYM.TRACEARRAYAPPENDT ],
[ RTLSYM.ARRAYAPPENDCTX, RTLSYM.TRACEARRAYAPPENDCTX ],


[ RTLSYM.ARRAYSETLENGTHT, RTLSYM.TRACEARRAYSETLENGTHT ],
[ RTLSYM.ARRAYSETLENGTHIT, RTLSYM.TRACEARRAYSETLENGTHIT ],
Expand Down
Loading