Skip to content

Remove FUNCFLAG.compileTimeOnly #14847

Merged
dlang-bot merged 1 commit intodlang:masterfrom
RazvanN7:remove_compileTimeOnly
Jan 26, 2023
Merged

Remove FUNCFLAG.compileTimeOnly #14847
dlang-bot merged 1 commit intodlang:masterfrom
RazvanN7:remove_compileTimeOnly

Conversation

@RazvanN7
Copy link
Contributor

@RazvanN7 RazvanN7 commented Jan 25, 2023

Because it is redundant with FUNCFLAG.skipCodegen and used instead of SCOPE.compile.

As detailed in #14846 , the addition of compileTimeOnly was a hack to mask another hack.

#14846 untied the original hack so we can now tidy up the mess.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @RazvanN7! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#14847"

Copy link
Contributor

@dkorpel dkorpel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just needs to update the headers

@RazvanN7 RazvanN7 force-pushed the remove_compileTimeOnly branch from d150338 to cb0358e Compare January 26, 2023 11:43
@RazvanN7 RazvanN7 requested a review from ibuclaw as a code owner January 26, 2023 11:43
@dkorpel
Copy link
Contributor

dkorpel commented Jan 26, 2023

They should also be removed from declaration.h:639

    bool isCompileTimeOnly() const;
    bool isCompileTimeOnly(bool v);

@RazvanN7 RazvanN7 force-pushed the remove_compileTimeOnly branch from cb0358e to 19d8ef7 Compare January 26, 2023 12:56
@RazvanN7
Copy link
Contributor Author

@dkorpel ready, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants