fix Issue 17605 - [REG2.066.0] __traits(compiles, closure) adds link-…#7897
Merged
WalterBright merged 1 commit intodlang:masterfrom Feb 17, 2018
Merged
fix Issue 17605 - [REG2.066.0] __traits(compiles, closure) adds link-…#7897WalterBright merged 1 commit intodlang:masterfrom
WalterBright merged 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @WalterBright! Bugzilla references
|
PetarKirov
reviewed
Feb 15, 2018
test/runnable/betterc.d
Outdated
| /*******************************************/ | ||
| // https://issues.dlang.org/show_bug.cgi?id=17605 | ||
|
|
||
| extern (C) test17605() |
Member
There was a problem hiding this comment.
Needs return type: extern (C) void test17605().
Member
Author
|
Clearly this is not a simple problem. Will need to work on it more. |
WalterBright
force-pushed
the
fix17605
branch
2 times, most recently
from
d2e5ac0 to
811ad94
Compare
…time reference to _d_allocmemory
WalterBright
force-pushed
the
fix17605
branch
from
811ad94 to
1c6169c
Compare
Contributor
|
Easier to review with https://github.com/dlang/dmd/pull/7897/files?w=1 |
Contributor
|
@WalterBright Is this ready to go? |
Member
Author
|
Yes, it's ready. |
JinShil
approved these changes
Feb 16, 2018
This was referenced Jan 25, 2023
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…time reference to _d_allocmemory
The offending line was added by #3625 so we'll try removing the line and see what happens.