Issue 6359 - Pure/@safe-inference should not be affected by __traits(compiles)#3625
Merged
WalterBright merged 4 commits intodlang:masterfrom Jun 6, 2014
Merged
Issue 6359 - Pure/@safe-inference should not be affected by __traits(compiles)#3625WalterBright merged 4 commits intodlang:masterfrom
WalterBright merged 4 commits intodlang:masterfrom
Conversation
src/expression.c
Outdated
Member
There was a problem hiding this comment.
This should be redone to be:
if (v->ident == Id::gate)
WalterBright
added a commit
that referenced
this pull request
Jun 6, 2014
Issue 6359 - Pure/@safe-inference should not be affected by __traits(compiles)
Contributor
There was a problem hiding this comment.
Wow, what a completely self-explanatory function name. And thankfully, there is even a doc comment to explain what is going on!
Member
|
This pull request may have introduced a regression: |
Member
|
The regression is caused by: https://github.com/dlang/dmd/pull/3625/files#diff-43282ebf5a2de5fdbcb3b5083ddf949dR1294 where |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=6359