Skip to content

Comments

Fix Issue 13063 - enum is allowed as storage class for functions#15405

Merged
RazvanN7 merged 3 commits intodlang:masterfrom
ntrel:enum-fn
Jul 14, 2023
Merged

Fix Issue 13063 - enum is allowed as storage class for functions#15405
RazvanN7 merged 3 commits intodlang:masterfrom
ntrel:enum-fn

Conversation

@ntrel
Copy link
Contributor

@ntrel ntrel commented Jul 12, 2023

No description provided.

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
13063 normal `enum` is allowed as storage class for functions

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + dmd#15405"

@ntrel ntrel marked this pull request as ready for review July 12, 2023 14:17
@RazvanN7
Copy link
Contributor

Maybe also add a changelog entry? I expect that there might be code out there abusing this pattern.

@RazvanN7 RazvanN7 merged commit 8fe5144 into dlang:master Jul 14, 2023
@CyberShadow
Copy link
Member

@ntrel @RazvanN7 @WalterBright This should have been a deprecation, it caused downstream breakage with no warning:
https://aur.archlinux.org/packages/btdu#comment-928456

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants