Skip to content

Comments

[stable] Make enum function a deprecation, not an error#15533

Merged
dlang-bot merged 2 commits intodlang:stablefrom
ntrel:enum-fn-dep
Aug 12, 2023
Merged

[stable] Make enum function a deprecation, not an error#15533
dlang-bot merged 2 commits intodlang:stablefrom
ntrel:enum-fn-dep

Conversation

@ntrel
Copy link
Contributor

@ntrel ntrel commented Aug 11, 2023

The error broke btdu - see: #15405 (comment)

@CyberShadow

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "stable + dmd#15533"

}
else if (t.ty == Tfunction)
{
/* @@@DEPRECATED_2.105.1@@@
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version should say when to turn it into an error, 10 releases ahead by default, so 2.115

Copy link
Member

@CyberShadow CyberShadow Aug 11, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @dkorpel meant to change the version in the deprecated tag:

Suggested change
/* @@@DEPRECATED_2.105.1@@@
/* @@@DEPRECATED_2.115@@@

Copy link
Member

@CyberShadow CyberShadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix!

@dlang-bot dlang-bot merged commit 54742dd into dlang:stable Aug 12, 2023
@ibuclaw ibuclaw mentioned this pull request Aug 15, 2023
maxhaton pushed a commit that referenced this pull request Aug 15, 2023
[stable] Make enum function a deprecation, not an error

Signed-off-by: Dennis <dkorpel@users.noreply.github.com>
Signed-off-by: Vladimir Panteleev <CyberShadow@users.noreply.github.com>
Signed-off-by: Petar Kirov <PetarKirov@users.noreply.github.com>
Merged-on-behalf-of: Vladimir Panteleev <CyberShadow@users.noreply.github.com>
This was referenced Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants