[stable] Make enum function a deprecation, not an error#15533
[stable] Make enum function a deprecation, not an error#15533dlang-bot merged 2 commits intodlang:stablefrom
Conversation
|
Thanks for your pull request and interest in making D better, @ntrel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "stable + dmd#15533" |
compiler/src/dmd/parse.d
Outdated
| } | ||
| else if (t.ty == Tfunction) | ||
| { | ||
| /* @@@DEPRECATED_2.105.1@@@ |
There was a problem hiding this comment.
The version should say when to turn it into an error, 10 releases ahead by default, so 2.115
There was a problem hiding this comment.
I think @dkorpel meant to change the version in the deprecated tag:
| /* @@@DEPRECATED_2.105.1@@@ | |
| /* @@@DEPRECATED_2.115@@@ |
CyberShadow
left a comment
There was a problem hiding this comment.
Thank you for the quick fix!
[stable] Make enum function a deprecation, not an error Signed-off-by: Dennis <dkorpel@users.noreply.github.com> Signed-off-by: Vladimir Panteleev <CyberShadow@users.noreply.github.com> Signed-off-by: Petar Kirov <PetarKirov@users.noreply.github.com> Merged-on-behalf-of: Vladimir Panteleev <CyberShadow@users.noreply.github.com>
The error broke
btdu- see: #15405 (comment)@CyberShadow