Issue 1983 - Delegates violate const by 9rnsr · Pull Request #2130 · dlang/dmd

9rnsr · 2013-06-04T13:11:08Z

http://d.puremagic.com/issues/show_bug.cgi?id=1983

~~Depends on #2125, #2123, and dlang/phobos#1331~~.

Add ambiguous type to represent the type which comes from overloaded symbol.
Carry overload information properly, and use it.

9rnsr · 2013-07-04T14:36:06Z

Add fix for Issue 7322 - Taking address of deprecated functions isn't refused

9rnsr · 2013-07-26T15:33:55Z

Bug ~~1083~~ 1983 is a remaining big hole in type-system. Fixing it has a high priority toward finalization of D2 compiler implementation.
And, this PR will become a basis for other overloaded-symbol related language specifications those are yet not well defined (template overload set merging, access check for symbols through template alias parameter, etc).
Please review this...

ghost · 2013-07-26T16:35:43Z

Are you really talking about bug 1083? By the way, the are several others issues related to 1983:
http://d.puremagic.com/issues/show_bug.cgi?id=8781
http://d.puremagic.com/issues/show_bug.cgi?id=9149
and at least another two, but cannot find them now.

9rnsr · 2013-07-26T17:25:42Z

Sorry, I'm talking about bug 1983.
Issue 8781 is a dup of 1983.
And AFAIK, issue 9149 is not a bug. D2 type system cannot reject the code filed in it.

9rnsr · 2014-01-31T16:12:13Z

Updated.

9rnsr · 2014-04-16T10:47:15Z

Updated for the issues:

Issue 7549 - typeof of overloaded function picks the lexically first one
Issue 8868 - overload resolution of &x.g() incorrectly chooses delegate over function pointer
Issue 9027 - Getting address of overloaded function using cast selects the lexically first one if there is no match

quickfur · 2014-08-06T14:39:08Z

ping
The supplementary Phobos pull has been merged a year ago. What's holding up this PR?

andralex · 2015-01-27T05:42:33Z

ping @WalterBright @yebblies @MartinNowak please review

9rnsr · 2015-01-27T14:01:21Z

During two years, I'm repeatedly rebasing this PR to keep mergeable. Type system bug is much higher priority than other any enhancement features.

I hope to other committers to be prefer fixing essential language bugs than cosmetic syntax changes.

9rnsr · 2015-02-21T06:42:24Z

Ping.

quickfur · 2015-02-21T15:51:18Z

This has been a bug for 7 years. Is this ever going to get fixed?!

yebblies · 2015-02-21T16:05:15Z

Right after bug 314.

ibuclaw · 2016-02-14T09:50:33Z

Oh, didn't see that there. :-)

ibuclaw · 2016-02-14T10:02:17Z

src/mtype.d

+                            e = DsymbolExp.resolve(loc, sc, s, false);      // todo
                        else
-                            e = new VarExp(loc, s.isDeclaration());
+                            e = new VarExp(loc, s.isDeclaration(), false);  // todo


I've tested a new better fix for VarExp.hasOverloads and others' setting. Now it's changed to give true, and the commit is properly in #5198.

Carry information which function is overloaded and use it properly.

…rst one

…legate over function pointer

…selects the lexically first one if there is no match

Geod24 · 2018-09-06T09:38:39Z

Since @9rnsr has sadly disappeared from the D scene, I'm going to send this to the Phantom Zone.
One reason to do so is that our queue of PR has grown quite large, and this is still being scheduled from time to time (e.g. see the auto-tester).

9rnsr mentioned this pull request Jun 4, 2013

Supplemental change for Issue 1983 - Delegates violate const dlang/phobos#1331

Merged

This was referenced Jul 4, 2013

Fix Issue 7322 -- Taking address of deprecated functions isn't refused #1064

Closed

Issue 7538 - All kinds of property functions should be called before getting their types inside typeof #2123

Merged

9rnsr mentioned this pull request Aug 30, 2013

fix Issue 10711 - shared phobos library should not depend on _Dmain #2476

Merged

9rnsr mentioned this pull request Sep 9, 2013

Fix genCmain code to remove ambiguity of &main expression #2540

Merged

9rnsr force-pushed the fix1983 branch from c2b3d13 to 684530d Compare September 1, 2014 04:02

9rnsr force-pushed the fix1983 branch from 684530d to 80bdc2c Compare September 15, 2014 06:36

9rnsr force-pushed the fix1983 branch 4 times, most recently from 7b219ec to d707e3b Compare January 19, 2015 10:28

9rnsr force-pushed the fix1983 branch from d707e3b to e19ceea Compare January 29, 2015 02:31

9rnsr force-pushed the fix1983 branch from e19ceea to 89100e5 Compare February 16, 2015 16:49

9rnsr mentioned this pull request Feb 16, 2015

[REG2.064] Issue 13009 - inout overload conflicts with non-inout when used via alias this #4417

Merged

9rnsr force-pushed the fix1983 branch 3 times, most recently from ed209fa to a7fd8f8 Compare February 21, 2015 06:41

9rnsr force-pushed the fix1983 branch from a7fd8f8 to 7292d21 Compare February 24, 2015 03:03

ibuclaw mentioned this pull request Feb 14, 2016

Issue 14989 - Overload merge sometimes doesn't work #5009

Merged

ibuclaw reviewed Feb 14, 2016
View reviewed changes

9rnsr force-pushed the fix1983 branch 2 times, most recently from ceb16bc to 2ae5ef5 Compare February 14, 2016 12:26

9rnsr mentioned this pull request Feb 14, 2016

Cleanup hasOverloads #5198

Merged

9rnsr force-pushed the fix1983 branch 2 times, most recently from 1f45505 to 135f004 Compare February 16, 2016 00:52

9rnsr force-pushed the fix1983 branch from 135f004 to db1acab Compare February 29, 2016 23:26

9rnsr mentioned this pull request Mar 2, 2016

[REG2.031] Issue 14965 - Forward reference to inferred return type of function call when using auto return type #5202

Merged

3 tasks

9rnsr force-pushed the fix1983 branch from db1acab to 821d073 Compare March 9, 2016 14:02

9rnsr force-pushed the fix1983 branch from 821d073 to 1dea08d Compare March 27, 2016 11:26

9rnsr force-pushed the fix1983 branch from 1dea08d to 83f272a Compare April 8, 2016 17:21

9rnsr force-pushed the fix1983 branch from 83f272a to 69c039f Compare April 25, 2016 01:03

9rnsr added 6 commits April 25, 2016 10:07

Add "ambiguous type" and ready to use it

ca94256

fix Issue 1983 - Delegates violate const

39c1cc0

Carry information which function is overloaded and use it properly.

fix Issue 7322 - Taking address of deprecated functions isn't refused

83e1587

fix Issue 7549 - typeof of overloaded function picks the lexically fi…

550c236

…rst one

fix Issue 8868 - overload resolution of &x.g() incorrectly chooses de…

84a8909

…legate over function pointer

fix Issue 9027 - Getting address of overloaded function using cast …

0df8529

…selects the lexically first one if there is no match

9rnsr force-pushed the fix1983 branch from 69c039f to 0df8529 Compare April 25, 2016 01:07

ibuclaw mentioned this pull request Dec 23, 2017

Add Type.tambig and make ready to use. #7503

Open

dlang-bot added Review:Needs Rebase Review:Needs Work Review:stalled labels Jan 1, 2018

ibuclaw self-assigned this Jan 30, 2018

Geod24 added the Review:Phantom Zone Has value/information for future work, but closed for now label Sep 6, 2018

Geod24 closed this Sep 6, 2018

dlang-bot added the Severity:Bug Fix label Sep 6, 2018

Uh oh!

Comments

Conversation

9rnsr commented Jun 4, 2013

Uh oh!

9rnsr commented Jul 4, 2013

Uh oh!

9rnsr commented Jul 26, 2013

Uh oh!

ghost commented Jul 26, 2013

Uh oh!

9rnsr commented Jul 26, 2013

Uh oh!

9rnsr commented Jan 31, 2014

Uh oh!

9rnsr commented Apr 16, 2014

Uh oh!

quickfur commented Aug 6, 2014

Uh oh!

andralex commented Jan 27, 2015

Uh oh!

9rnsr commented Jan 27, 2015

Uh oh!

9rnsr commented Feb 21, 2015

Uh oh!

quickfur commented Feb 21, 2015

Uh oh!

yebblies commented Feb 21, 2015

Uh oh!

ibuclaw commented Feb 14, 2016

Uh oh!

ibuclaw Feb 14, 2016

Choose a reason for hiding this comment

Uh oh!

9rnsr Feb 14, 2016

Choose a reason for hiding this comment

Uh oh!

Geod24 commented Sep 6, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants