Skip to content

Comments

[REG2.064] Issue 13009 - inout overload conflicts with non-inout when used via alias this#4417

Merged
braddr merged 2 commits intodlang:masterfrom
9rnsr:fix13009
Feb 21, 2015
Merged

[REG2.064] Issue 13009 - inout overload conflicts with non-inout when used via alias this#4417
braddr merged 2 commits intodlang:masterfrom
9rnsr:fix13009

Conversation

@9rnsr
Copy link
Contributor

@9rnsr 9rnsr commented Feb 16, 2015

https://issues.dlang.org/show_bug.cgi?id=13009

Considering better match for the overloaded alias this without valid this expression is a new feature.
(The issue case was accidentally worked since 2.063.)

FuncDeclaration::overloadModMatch comes from #2130.

src/mtype.c Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need comment explaining what this function does.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that it does mostly same work with MODmethodConv. I'll improve it rather than adding a new function.

@WalterBright
Copy link
Member

Auto-merge toggled on

braddr added a commit that referenced this pull request Feb 21, 2015
[REG2.064] Issue 13009 - inout overload conflicts with non-inout when used via alias this
@braddr braddr merged commit d30acc5 into dlang:master Feb 21, 2015
@9rnsr 9rnsr deleted the fix13009 branch February 21, 2015 12:22
@9rnsr 9rnsr added this to the 2.067 milestone Mar 1, 2015
braddr added a commit that referenced this pull request Mar 1, 2015
[REG2.064] Issue 13009 - inout overload conflicts with non-inout when used via alias this
@CyberShadow
Copy link
Member

@9rnsr This fix seems to be incomplete, see https://issues.dlang.org/show_bug.cgi?id=13009#c16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants