Fix DIP1000 scope array of arrays comparison#21947
Fix DIP1000 scope array of arrays comparison#21947thewilsonator merged 3 commits intodlang:masterfrom
Conversation
|
Thanks for your pull request and interest in making D better, @Albert24GG! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#21947" |
|
any idea what is causing CI to fail? |
|
I managed to fix the issue by explicitly handling static arrays through override functions. I am not sure why that test was previously failing only on windows, |
|
Thanks for fixing this so quickly! |
This PR fixes #21945. The issue was that
__equalsaccepted only dynamic array/slice arguments, so calling it with static arrays caused an explicit cast to slice, which in turn triggered some error in the escape checking logic.