Skip to content

Fix DIP1000 scope array of arrays comparison #21947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thewilsonator merged 3 commits into from
Oct 10, 2025
Merged

Fix DIP1000 scope array of arrays comparison #21947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1428901
Fix scoped static array equality error when compiling with `DIP1000`
Albert24GG Oct 8, 2025
9b62330
Add scoped static array equality test
Albert24GG Oct 8, 2025
01f9fdb
Add `__equals` overrides for static arrays to avoid copies
Albert24GG Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions compiler/test/compilable/fix21945.d
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
// REQUIRED_ARGS: -preview=dip1000

void assertEq(scope int[][3] x) @safe
{
bool b = x == x;
}
15 changes: 15 additions & 0 deletions druntime/src/core/internal/array/equality.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,21 @@ bool __equals(T1, T2)(scope T1[] lhs, scope T2[] rhs) @trusted
return (cast(PureType)&isEqual!(T1,T2))(lhs, rhs, lhs.length);
}

pragma(inline, true)
bool __equals(T1, T2, size_t N)(scope ref T1[N] lhs, scope T2[] rhs) @trusted {
return __equals(lhs[], rhs);
}

pragma(inline, true)
bool __equals(T1, T2, size_t N)(scope T1[] lhs, scope ref T2[N] rhs) @trusted {
return __equals(lhs, rhs[]);
}

pragma(inline, true)
bool __equals(T1, T2, size_t N, size_t M)(scope ref T1[N] lhs, scope ref T2[M] rhs) @trusted {
return __equals(lhs[], rhs[]);
}

/******************************
* Helper function for __equals().
* Outlined to enable __equals() to be inlined, as dmd cannot inline loops.
Expand Down
Loading