fix regression in #20863 triggering an assertion if TypeInfo_AssociativeArray is misdefined#22126
Merged
thewilsonator merged 1 commit intodlang:masterfrom Nov 21, 2025
Merged
Conversation
Contributor
|
Thanks for your pull request, @rainers! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#22126" |
schveiguy
approved these changes
Nov 21, 2025
Member
schveiguy
left a comment
schveiguy
left a comment
There was a problem hiding this comment.
If it passes CI, probably good.
ibuclaw
reviewed
Nov 21, 2025
Member
|
Judging from the errors, this ought to be at the top of the visit method. override void visit(TypeInfoAssociativeArrayDeclaration ti)
{
if (ti.semanticRun >= PASS.semantic3)
return;
ti.semanticRun = PASS.semantic3;
|
…ociativeArray is misdefined
Member
Author
Good point, added. |
thewilsonator
approved these changes
Nov 21, 2025
ibuclaw
reviewed
Nov 24, 2025
| tmpl.minst = sc2._module.importedFrom; // ensure it gets emitted | ||
| if (!e.isErrorExp()) | ||
| { | ||
| assert(e.isVarExp() && e.type.isTypeFunction()); |
Member
There was a problem hiding this comment.
I've just realised that this will still trigger an assert and ICE if druntime is seriously mismatched with the compiler by declaring these fields but of a different type.
class TypeInfo_AssociativeArray
{
alias aaOpEqual(K, V) = () => false;
alias aaGetHash(K, V) = () => 0;
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fail gracefully with empty declaration.