semantic3: Fix more assertions if TypeInfo_AssociativeArray is misdefined#22143
Merged
thewilsonator merged 1 commit intodlang:masterfrom Nov 24, 2025
Merged
semantic3: Fix more assertions if TypeInfo_AssociativeArray is misdefined#22143thewilsonator merged 1 commit intodlang:masterfrom
thewilsonator merged 1 commit intodlang:masterfrom
Conversation
Contributor
|
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + dmd#22143" |
rainers
reviewed
Nov 24, 2025
| ti.xtoHash = e.isVarExp().var; | ||
| if (auto tmpl = ti.xtoHash.parent.isTemplateInstance()) | ||
| tmpl.minst = sc2._module.importedFrom; // ensure it gets emitted | ||
| if (!e.isVarExp() || !e.type.isTypeFunction()) |
Member
There was a problem hiding this comment.
Should this test include the ti.xtoHash.parent.isTemplateInstance() check, too? Otherwise the message might not match the condition.
Member
Author
There was a problem hiding this comment.
makeDotExp returns a DotTemplateInstanceExp, so if it doesn't resolve to a template, then its value will be an ErrorExp.
thewilsonator
approved these changes
Nov 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Probably the error may need to be more descriptive (say what kind of template function is expected). Anything is better than ICE'ing.