Conversation
src/cast.c
Outdated
Contributor
There was a problem hiding this comment.
((TypeSArray *)t1b)->dim->toInteger()? Or just copy, clear deco, and modify next? What about slices of pointers?
Member
Author
There was a problem hiding this comment.
Both of those seem like more work. Yes, I forgot about pointer slices. Will fix.
Contributor
|
Looks good. |
Contributor
|
Auto-merge toggled on |
Member
|
This pull request introduced a regression: |
ibuclaw
pushed a commit
to ibuclaw/dmd
that referenced
this pull request
Jul 10, 2022
Fix 21544 - -checkaction=context formats enum members as their base type
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds implicit conversions to slice expressions, analogously to pointer offset expressions.
Also fixes a typo error in the pointer offset expression conversion.