Skip to content

DIP29-3: function calls#3352

Merged
9rnsr merged 1 commit intodlang:masterfrom
WalterBright:DIP29-3
Mar 4, 2014
Merged

DIP29-3: function calls#3352
9rnsr merged 1 commit intodlang:masterfrom
WalterBright:DIP29-3

Conversation

@WalterBright
Copy link
Member

This is a large step forward in better implicit conversions.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you forget to #undef LOG at the end? Please just comment these out instead of putting #ifs everywhere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@yebblies
Copy link
Contributor

yebblies commented Mar 3, 2014

Walter, what exactly are you doing here? You do know that mutable return values of pure functions have converted to immutable for ~3 years now, right? I wouldn't have to ask if you would write a meaningful description for the pull request.

@WalterBright
Copy link
Member Author

You do know that mutable return values of pure functions have converted to immutable for ~3 years now, right?

Try the test cases I supplied with the PR - they fail otherwise. The trouble is that the existing version did not check if the arg expressions were convertible - only that the types were.

@WalterBright
Copy link
Member Author

I wouldn't have to ask if you would write a meaningful description for the pull request.

See http://wiki.dlang.org/DIP29

@yebblies
Copy link
Contributor

yebblies commented Mar 3, 2014

See http://wiki.dlang.org/DIP29

So it implements the entire DIP?

@WalterBright
Copy link
Member Author

So it implements the entire DIP?

No, just the function calls. See the previous DIP29 bits I've done, the ptr+offset and array[i] expressions:

#3336
#3319

I'm doing it piecemeal because it's much easier to review it that way - each change is fairly standalone.

@9rnsr
Copy link
Contributor

9rnsr commented Mar 4, 2014

LGTM.

@9rnsr
Copy link
Contributor

9rnsr commented Mar 4, 2014

Auto-merge toggled on

9rnsr added a commit that referenced this pull request Mar 4, 2014
@9rnsr 9rnsr merged commit 34487d8 into dlang:master Mar 4, 2014
@WalterBright WalterBright deleted the DIP29-3 branch March 4, 2014 22:36
@wilzbach
Copy link
Contributor

wilzbach commented Mar 4, 2016

@WalterBright I know time is very short, but would you be so kind to update the DIP's status?
I just went through the git log to see that it's actually not "Draft", but "Implemented"?

http://wiki.dlang.org/DIP29

(might be a good idea to do a short house keeping and see whether there are other DIPs with changed status out there - thanks :) )

ibuclaw pushed a commit to ibuclaw/dmd that referenced this pull request Jul 10, 2022
core.lifetime.emplace(): Properly forward r/lvalue-ness of arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants