Conversation
There was a problem hiding this comment.
Did you forget to #undef LOG at the end? Please just comment these out instead of putting #ifs everywhere.
|
Walter, what exactly are you doing here? You do know that mutable return values of pure functions have converted to immutable for ~3 years now, right? I wouldn't have to ask if you would write a meaningful description for the pull request. |
Try the test cases I supplied with the PR - they fail otherwise. The trouble is that the existing version did not check if the arg expressions were convertible - only that the types were. |
|
|
So it implements the entire DIP? |
|
LGTM. |
|
Auto-merge toggled on |
|
@WalterBright I know time is very short, but would you be so kind to update the DIP's status? (might be a good idea to do a short house keeping and see whether there are other DIPs with changed status out there - thanks :) ) |
core.lifetime.emplace(): Properly forward r/lvalue-ness of arguments
This is a large step forward in better implicit conversions.