Skip to content

fix root/rmem.d to follow issue 14401 fix in druntime.#4572

Merged
yebblies merged 1 commit intodlang:masterfrom
9rnsr:fix14401
Apr 9, 2015
Merged

fix root/rmem.d to follow issue 14401 fix in druntime.#4572
yebblies merged 1 commit intodlang:masterfrom
9rnsr:fix14401

Conversation

@9rnsr
Copy link
Contributor

@9rnsr 9rnsr commented Apr 8, 2015

The type of typeid(SomeClass).init is changed in dlang/druntime#1205.

I'm not sure why the current auto-tester does not detect the error.

@9rnsr
Copy link
Contributor Author

9rnsr commented Apr 8, 2015

Auto-merge toggled on

@9rnsr
Copy link
Contributor Author

9rnsr commented Apr 8, 2015

Ah, I understand. magicport is built by using HOST_DC, and it would be 2.067 in auto-tester.

@9rnsr
Copy link
Contributor Author

9rnsr commented Apr 8, 2015

Auto-merge toggled off

@9rnsr
Copy link
Contributor Author

9rnsr commented Apr 8, 2015

So, maybe this is too early fix to build magicport with git-head druntime? I'm not sure the workflow to update magicport code...
@yebblies Do you know that?

@yebblies
Copy link
Contributor

yebblies commented Apr 9, 2015

I think this is correct, ddmd should always compile with master and with 2.067.

@yebblies
Copy link
Contributor

yebblies commented Apr 9, 2015

Auto-merge toggled on

yebblies added a commit that referenced this pull request Apr 9, 2015
fix root/rmem.d to follow issue 14401 fix in druntime.
@yebblies yebblies merged commit 7f8f27c into dlang:master Apr 9, 2015
@9rnsr
Copy link
Contributor Author

9rnsr commented Apr 9, 2015

I understand, thanks.

@9rnsr 9rnsr deleted the fix14401 branch April 9, 2015 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants