This repository was archived by the owner on Oct 12, 2022. It is now read-only.
Issue 14401 - typeid(shared X).init is empty for class types#1205
Merged
andralex merged 2 commits intodlang:masterfrom Apr 3, 2015
Merged
Issue 14401 - typeid(shared X).init is empty for class types#1205andralex merged 2 commits intodlang:masterfrom
andralex merged 2 commits intodlang:masterfrom
Conversation
`TypeInfo_Class` needs to override `init()` method for the `TypeInfo_Const` and its derived TypeInfo classes.
This is a small but necessary breaking change. If a class instance contains reference type fields, the instance image must be typed as const(void)[] rather than byte[n].
Member
There was a problem hiding this comment.
urgh... we really should have a compiler error for this stuff
Member
|
Auto-merge toggled on |
Member
|
@9rnsr thanks! Could you please take a look at the failures, they seem related. |
Member
|
compiler errors should be fixed with the merge of dlang/phobos#3143 |
Member
|
@schveiguy thanks |
andralex
added a commit
that referenced
this pull request
Apr 3, 2015
Issue 14401 - typeid(shared X).init is empty for class types
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.dlang.org/show_bug.cgi?id=14401
TypeInfo_Classneeds to overrideinit()method for theTypeInfo_Constand its derived TypeInfo classes.Now all
typeid(X).initfor any typeXis typed asconst(void)[].This is a small but necessary breaking change. If a class instance contains reference type fields, the instance image must be typed as
const(void)[]rather thanbyte[n].