Refactor: fix mismatch of Scope class member declaration

[9rnsr]

Separated from #5750.

[mathias-lang-sociomantic]

Why the change of style ? Otherwise 👍

[9rnsr]

Without the style change, the bugfix would break vertical alignment of line comments in scope.h. I think placing comment in own line would be better to reduce bike-shed discussion.

[mathias-lang-sociomantic]

Without the style change, the bugfix would break vertical alignment of line comments in scope.h. I think placing comment in own line would be better to reduce bike-shed discussion.

Fine by me (I tend to prefer this style anyway).
Maybe we could have a style guide (as part of a CONTRIBUTING.md file) to reduce the amount of bike shedding even more ?

[9rnsr]

Yes... I think we should do it as fast as possible.

Walter is not active for such the guideline documents, then someone should work for that.

To me writing long documentation is much painful than contributing code, because I'm not a native English user. But I would have to do it...

[mathias-lang-sociomantic]

I'll gladly help if you can provide the key point.
Could you contact me via email ? Both my personal and company email are on bugzilla under my real name.

[9rnsr]

Thanks for your offer, but the guideline would be a list of my points in the first time. If it would not fit the Walter's points while reviewing, your work would be wasted. So first I should write it in my responsibility.
After the PR opened, I'll welcome review comments.

[WalterBright]

I see no reason for this change. It's just churn.

[yebblies]

I think placing comment in own line would be better to reduce bike-shed discussion.

It seems you're wrong about this.

[WalterBright]

Auto-merge toggled on