refactor: Parser should take a string argument#5832
Merged
9rnsr merged 1 commit intodlang:masterfrom Jun 3, 2016
Merged
Conversation
WalterBright
changed the title
WalterBright
force-pushed
the
parser
branch
2 times, most recently
from
7bbd613 to
ecb3dbe
Compare
Contributor
|
Auto-merge toggled on |
| * allocated by mem.xmalloc(). | ||
| */ | ||
| final const(char)* toStringz() const | ||
| extern (D) final const(char)[] toStringz() const |
Contributor
There was a problem hiding this comment.
In this case, what's expected ? Should we just ignore the C++ side, or remove it (or something else) ?
Contributor
There was a problem hiding this comment.
In Walter's mind, the mismatch between D and C++ code is less important issue than frustration about code style.
Refer: #5751.
Member
Author
There was a problem hiding this comment.
It's never called from C++ code anyway, so I just removed it from expression.h
Contributor
There was a problem hiding this comment.
Please be really careful when doing this with virtual functions. The C++ and D sides do not share vtables, so it might not get noticed immediately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
strlen()must die.