fix Issue 11176 - array.ptr in @safe code may point past end of array by WalterBright · Pull Request #5860 · dlang/dmd

WalterBright · 2016-06-12T08:54:00Z

https://issues.dlang.org/show_bug.cgi?id=11176

WalterBright · 2016-06-12T09:20:01Z

This is likely to be disruptive.

WalterBright · 2016-06-12T09:22:19Z

Depends on dlang/druntime#1590 and dlang/phobos#4426

quickfur · 2016-06-14T15:35:16Z

LGTM. I like this, it's a neat solution to the nasty can o' worms about when/whether/how .ptr should/shouldn't be allowed in @safe code. Disruptive, yes, but it does solve the problem in a nice, self-contained way.

JackStouffer · 2016-06-14T15:44:55Z

Looks like there are still some std.format issues

andralex · 2016-06-16T00:38:29Z

I'll mark this for merging.

andralex · 2016-06-16T00:38:40Z

Auto-merge toggled on

WalterBright · 2016-06-18T21:02:50Z

This is blocked by numerous Phobos issues with .ptr

WalterBright · 2016-07-01T07:27:43Z

Auto-merge toggled off

WalterBright · 2016-07-01T07:28:23Z

Turned off auto-merge for the time being so the autotester doesn't waste time on this while it is blocked.

MartinNowak · 2016-07-26T06:51:05Z

And again, and again, and again: Stop breaking code!

This is likely to be disruptive.

You already mention it yourself, but still do it.

Depends on dlang/druntime#1590 and dlang/phobos#4426

As always, this is a lie. You're about to break almost 1K dub packages that all need similar PRs.
We'll never be able to build a healthy ecosystem of keeping trashing working code at that pace.
The mechanism to properly do such changes is simple and well established, instead of breaking code, you introduce a deprecation that informs people about the upcoming error, then turn it into an error a few month later when the majority of packages is already fixed.

dlang-bot · 2016-08-24T10:23:53Z

@WalterBright, thanks for your PR! By analyzing the annotation information on this pull request, we identified @yebblies, @klickverbot and @9rnsr to be potential reviewers. @yebblies: The PR was automatically assigned to you, please reassign it if you were identified mistakenly.

(The DLang Bot is under development. If you experience any issues, please open an issue at its repo.)

codecov-io · 2016-08-25T19:40:04Z

Current coverage is 87.42% (diff: 66.66%)

Merging #5860 into master will increase coverage by <.01%

@@             master      #5860   diff @@
==========================================
  Files            98         97     -1   
  Lines         56216      56194    -22   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          49143      49126    -17   
+ Misses         7073       7068     -5   
  Partials          0          0

Powered by Codecov. Last update c0e821e...c8c1c8c

WalterBright · 2016-08-31T07:11:53Z

Blocked by #6097

WalterBright · 2016-09-05T06:57:37Z

This one is ready-to-merge now.

andralex · 2016-09-05T08:25:27Z

src/mtype.d

                e.error("%s is not an expression", e.toChars());
                return new ErrorExp();
            }
+            else if (!(flag & 2) && sc.func && !sc.intypeof && sc.func.setUnsafe() && global.params.safe)


so what's 2 again?

andralex · 2016-09-05T08:26:17Z

Let's use a symbol for that 2 before pulling this Thanks!

WalterBright · 2016-09-05T08:50:21Z

done

@safe

The following DMD PRs added more rigorous safety checks directly affecting this project: * dlang/dmd#5852 (fix Issue 15399 - unaligned pointers are not `@safe`) - triggered at line: https://github.com/kiith-sa/D-YAML/blob/v0.5.3/source/dyaml/emitter.d#L1011 * dlang/dmd#5940 (Unions may break immutability / unions with pointers are un-`@safe` ) - triggered at line: https://github.com/kiith-sa/D-YAML/blob/v0.5.3/source/dyaml/event.d#L230 * dlang/dmd#5876 (Casting from `void[]` to `T[]` is erroneously considered `@safe`) - triggered at line: https://github.com/kiith-sa/D-YAML/blob/v0.5.3/source/dyaml/loader.d#L186 * dlang/dmd#5860 (array.ptr in @safe code may point past end of array) - triggered at line: https://github.com/kiith-sa/D-YAML/blob/v0.5.3/source/dyaml/zerostring.d#L35

@safe

The following DMD PRs added more rigorous safety checks directly affecting this project: * dlang/dmd#5852 (fix Issue 15399 - unaligned pointers are not `@safe`) - triggered at line: https://github.com/kiith-sa/D-YAML/blob/v0.5.3/source/dyaml/emitter.d#L1011 * dlang/dmd#5940 (Unions may break immutability / unions with pointers are un-`@safe` ) - triggered at line: https://github.com/kiith-sa/D-YAML/blob/v0.5.3/source/dyaml/event.d#L230 * dlang/dmd#5876 (Casting from `void[]` to `T[]` is erroneously considered `@safe`) - triggered at line: https://github.com/kiith-sa/D-YAML/blob/v0.5.3/source/dyaml/loader.d#L186 * dlang/dmd#5860 (array.ptr in @safe code may point past end of array) - triggered at line: https://github.com/kiith-sa/D-YAML/blob/v0.5.3/source/dyaml/zerostring.d#L35

WalterBright mentioned this pull request Jun 12, 2016

fix unsafe .ptr accesses in druntime dlang/druntime#1590

Merged

WalterBright mentioned this pull request Jun 12, 2016

fix unsafe .ptr access in Phobos dlang/phobos#4426

Merged

WalterBright changed the title ~~fix https://issues.dlang.org/show_bug.cgi?id=11176~~ fix Issue 11176 - array.ptr in @safe code may point past end of array Jun 13, 2016

PetarKirov mentioned this pull request Jun 14, 2016

fix some unsafe behavior in std.format dlang/phobos#4427

Merged

andralex added the Pending Autotester label Jun 16, 2016

WalterBright added Merge:Blocked and removed Pending Autotester labels Jun 18, 2016

WalterBright force-pushed the fix11176 branch from fe4c827 to 23a516b Compare July 25, 2016 06:39

This was referenced Jul 25, 2016

std.stdio: fix unsafe use of .ptr dlang/phobos#4651

Merged

cstring.d: fix unsafe use of .ptr dlang/phobos#4653

Merged

WalterBright force-pushed the fix11176 branch 3 times, most recently from 1bab969 to 64315d4 Compare July 26, 2016 00:26

This was referenced Jul 26, 2016

file.d: fix unsafe use of .ptr dlang/phobos#4658

Merged

core.time.d: fix unsafe use of .ptr dlang/druntime#1617

Merged

MartinNowak added the Review:Needs Work label Jul 26, 2016

WalterBright removed the Merge:Blocked label Aug 24, 2016

WalterBright force-pushed the fix11176 branch from 6696254 to d244f53 Compare August 24, 2016 10:23

dlang-bot assigned yebblies Aug 24, 2016

WalterBright mentioned this pull request Aug 24, 2016

refactor: prepare for later safety improvements #6077

Merged

WalterBright force-pushed the fix11176 branch from d244f53 to c8c1c8c Compare August 25, 2016 19:40

WalterBright mentioned this pull request Aug 29, 2016

add -safe switch #6097

Merged

WalterBright force-pushed the fix11176 branch 2 times, most recently from 5ee6de4 to 8306c8f Compare August 31, 2016 07:10

WalterBright added Merge:Blocked and removed Review:Needs Work labels Aug 31, 2016

WalterBright force-pushed the fix11176 branch from 8306c8f to 620eda5 Compare September 5, 2016 06:14

WalterBright removed the Merge:Blocked label Sep 5, 2016

WalterBright force-pushed the fix11176 branch 2 times, most recently from 7fb624a to 598bb04 Compare September 5, 2016 06:24

andralex reviewed Sep 5, 2016
View reviewed changes

fix https://issues.dlang.org/show_bug.cgi?id=11176

354c326

WalterBright force-pushed the fix11176 branch from 598bb04 to 354c326 Compare September 5, 2016 08:36

andralex merged commit 02d7ebe into dlang:master Sep 5, 2016

WalterBright deleted the fix11176 branch September 5, 2016 09:59

PetarKirov mentioned this pull request Nov 4, 2016

[trivial] Enable Markdown table syntax dlang-tour/core#471

Merged

PetarKirov mentioned this pull request Nov 4, 2016

Fix compilation with DMD 2.072.0 dlang-community/D-YAML#49

Closed

Uh oh!

Conversation

WalterBright commented Jun 12, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

WalterBright commented Jun 12, 2016

Uh oh!

WalterBright commented Jun 12, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

quickfur commented Jun 14, 2016

Uh oh!

JackStouffer commented Jun 14, 2016

Uh oh!

andralex commented Jun 16, 2016

Uh oh!

andralex commented Jun 16, 2016

Uh oh!

WalterBright commented Jun 18, 2016

Uh oh!

WalterBright commented Jul 1, 2016

Uh oh!

WalterBright commented Jul 1, 2016

Uh oh!

MartinNowak commented Jul 26, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dlang-bot commented Aug 24, 2016

Uh oh!

codecov-io commented Aug 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Current coverage is 87.42% (diff: 66.66%)

Uh oh!

WalterBright commented Aug 31, 2016

Uh oh!

WalterBright commented Sep 5, 2016

Uh oh!

andralex Sep 5, 2016

Choose a reason for hiding this comment

Uh oh!

WalterBright Sep 5, 2016

Choose a reason for hiding this comment

Uh oh!

andralex commented Sep 5, 2016

Uh oh!

WalterBright commented Sep 5, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

WalterBright commented Jun 12, 2016 •

edited

Loading

WalterBright commented Jun 12, 2016 •

edited

Loading

MartinNowak commented Jul 26, 2016 •

edited

Loading

codecov-io commented Aug 25, 2016 •

edited

Loading