refactor: prepare for later safety improvements#6077
Merged
andralex merged 1 commit intodlang:masterfrom Aug 25, 2016
Merged
Conversation
Contributor
|
@WalterBright, thanks for your PR! By analyzing the annotation information on this pull request, we identified @yebblies, @AndrejMitrovic and @9rnsr to be potential reviewers. @yebblies: The PR was automatically assigned to you, please reassign it if you were identified mistakenly. |
| final void setNoderefOperand() | ||
| { | ||
| if (e1.op == TOKdotid) | ||
| (cast(DotIdExp)e1).noderef = true; |
Member
There was a problem hiding this comment.
space after ) in cast throughout...
Contributor
There was a problem hiding this comment.
Seems like we should enable Dscanner here too ;-)
Member
|
ehm |
Contributor
|
Andrei, why do you always give advice on how to make a PR better but then merge it anyway? |
Member
|
Not always. At the end of the review I make the decision on whether that stops the merge or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I pulled out the common part of #5860 and made it a separate PR so that I can base more work on it without needing to pull all of 5860 just yet.