fix Issue 16188 - [REG2.069] ICE on invalid code#5925
fix Issue 16188 - [REG2.069] ICE on invalid code#5925WalterBright wants to merge 1 commit intodlang:masterfrom
Conversation
|
|
The code in AliasDeclaration.semantic() is the most unholy mess I've ever seen. |
WalterBright
added
Severity:Regression
|
I'm not real happy with this fix, as the wrong error message is generated, as described in the attached test case. The whole |
| overnext = null; | ||
| if (!overloadInsert(sx)) | ||
| ScopeDsymbol.multiplyDefined(Loc(), sx, this); | ||
| semanticRun = PASSsemanticdone; |
There was a problem hiding this comment.
Moving semanticRun here means repeated semantic for the error case. Is this intended?
There was a problem hiding this comment.
The change of src/declaration.d seems unrelated to the segfault fix, can we remove it?
If you intended to rerun semantic to produce the right error message, that apparently didn't work anyhow.
|
The overcomplicated alias stuff implementations are also the reason why I got stuck with #5847. |
|
d_do_test doesn't check the return code and silently let's a segfault in fail_compilation pass. |
|
See #5927 which addresses stable. |
3 participants
Unsure if this is the right fix. Let's see what the autotester says.