fix Issue 16188 - [REG2.069] ICE on invalid code#5927
Merged
WalterBright merged 2 commits intodlang:stablefrom Jul 9, 2016
Merged
fix Issue 16188 - [REG2.069] ICE on invalid code#5927WalterBright merged 2 commits intodlang:stablefrom
WalterBright merged 2 commits intodlang:stablefrom
Conversation
- I assume it was an attempt at showing the correct error message during opDispatch semantics (by rerunning semantic). But as we still get the wrong error message and this change isn't necessary to fix 16188, we better not merge it into stable.
Contributor
|
Member
|
Auto-merge toggled on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the second commit:
I assume it was an attempt at showing the correct error
message during opDispatch semantics (by rerunning semantic).
But as we still get the wrong error message and this change
isn't necessary to fix 16188, we better not merge it into stable.