Make Module.semantic override the base class's virtual function#6001
Merged
yebblies merged 1 commit intodlang:masterfrom Aug 7, 2016
Merged
Make Module.semantic override the base class's virtual function#6001yebblies merged 1 commit intodlang:masterfrom
yebblies merged 1 commit intodlang:masterfrom
Conversation
…a clearer interface. (compare with Module.importAll)
Contributor
Author
Contributor
|
Auto-merge toggled on |
JohanEngelen
added a commit
to JohanEngelen/dmd
that referenced
this pull request
Aug 8, 2016
JohanEngelen
added a commit
to JohanEngelen/ldc
that referenced
this pull request
Aug 8, 2016
JohanEngelen
added a commit
to JohanEngelen/ldc
that referenced
this pull request
Aug 8, 2016
This eliminates the hidden-virtuals warning flood. See dlang/dmd#6001 dlang/dmd@60f622f and dlang/dmd#6038
dnadlinger
added a commit
that referenced
this pull request
Aug 8, 2016
[Trivial] Fix C++ header after PR #6001.
UplinkCoder
pushed a commit
to UplinkCoder/dmd
that referenced
this pull request
Aug 31, 2016
Member
|
This pull request introduced a regression: |
JohanEngelen
added a commit
to JohanEngelen/dmd
that referenced
this pull request
Jun 25, 2017
…s" because it introduced a regression, see https://issues.dlang.org/show_bug.cgi?id=17548 This reverts commit 60f622f, reversing changes made to 9492814.
JohanEngelen
added a commit
to JohanEngelen/dmd
that referenced
this pull request
Jun 25, 2017
… part of reverting dlang#6001 This reverts commit 40fc716, reversing changes made to 3cec8aa.
JohanEngelen
added a commit
to JohanEngelen/dmd
that referenced
this pull request
Jun 25, 2017
JohanEngelen
added a commit
to JohanEngelen/dmd
that referenced
this pull request
Jun 25, 2017
…ear that they are not meant to override DSymbol.semantic*. Rework of dlang#6001 which caused regression issue 17548.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current Module interface defines
semantic()which is not overriding the Dsymbol baseclass'ssemantic(Scope*). This PR fixes that so that the interface is more clear.Compare with Module.importAll.
I chose to not name the
Scope*function argument to indicate that it is not used.